Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor shell resolving #121176

Merged
merged 47 commits into from Apr 16, 2021
Merged

Refactor shell resolving #121176

merged 47 commits into from Apr 16, 2021

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Apr 13, 2021

Fixes #119366
Part of #108804
Part of #117257
Fixes #121461

Remaining:

  • Workspace trust
  • TODOs
  • Add all platform settings
  • Test web
    • Icon being picked up but not path
  • Test remote

@Tyriar Tyriar added this to the April 2021 milestone Apr 13, 2021
@Tyriar Tyriar self-assigned this Apr 13, 2021
@Tyriar Tyriar marked this pull request as ready for review April 15, 2021 23:09
@Tyriar Tyriar merged commit 8d234a4 into main Apr 16, 2021
@Tyriar Tyriar deleted the tyriar/shell_resolve_refactor branch April 16, 2021 17:02
@github-actions github-actions bot locked and limited conversation to collaborators May 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adopt TerminalProfileResolverService for remote Allow setting of a default terminal profile
1 participant