Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delay restart prompt while settings sync is turning on #122132

Open
Tyriar opened this issue Apr 25, 2021 · 9 comments
Open

Delay restart prompt while settings sync is turning on #122132

Tyriar opened this issue Apr 25, 2021 · 9 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug settings-sync
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Apr 25, 2021

I just reinstalled Windows on a larger SSD and didn't have the greatest experience enabling setting sync.

Firstly I hit a vscode-auth.github.com error which told me to restart the install flow (I think this is a known issue as I've hit it before).

Then I got 2 sync progress notifications for some reason and got told to restart immediately after auth went through (which would stop the sync process):

image

Then I got a merge conflict issue which is weird because I literally just installed Insiders on a branch new machine:

image

After pressing cancel I was told to merge manually:

image

The merges view showed up, but didn't present anything to merge:

image

Pressing turn on settings sync then turned it on 🤷‍♂️

Restarting presented the keybinding conflict notification which showed the following conflicts:

image

Action items:

  1. Fix the duplicate progress indicator
  2. Can we defer the restart modal until after settings sync has completed? @sbatten?
  3. Why did I get a merge conflict?
  4. Why was there nothing to merge after getting the conflict?
  5. Can we also suppress/defer the language notification after enabling settings sync and do it automatically on restart? It's essentially saying the same thing as the restart to apply settings.
  6. Why are scm/input:Git:/ paths being synced in settings sync? They're local to the machine and also contain somewhat sensitive information. I needed to manually review the log before pasting in an issue, here's a snippet: "scm/input:Git:/Users/daimms/dev/Microsoft/node-pty","scm/input:Git:/Users/daimms/dev/Microsoft/vscode". Can we mark these keys as sensitive to avoid pasting into bug reports and/or needing the user to hand sanitize?
  7. Why did it show conflicts after restart?

Log:

[2021-04-25 05:42:38.618] [settingssync] [info] Using settings sync service https://vscode-sync-insiders.trafficmanager.net/
[2021-04-25 05:42:38.618] [settingssync] [info] Auto Sync is disabled.
[2021-04-25 06:20:25.491] [settingssync] [info] Did reset the local sync state.
[2021-04-25 06:20:25.514] [settingssync] [info] Did reset the local sync state.
[2021-04-25 06:20:25.516] [settingssync] [info] Settings: Skipped synchronizing settings as it is running already.
[2021-04-25 06:20:25.586] [settingssync] [info] Keybindings: Skipped synchronizing keybindings as it is running already.
[2021-04-25 06:20:25.591] [settingssync] [info] Snippets: Skipped synchronizing snippets as it is running already.
[2021-04-25 06:20:25.620] [settingssync] [info] GlobalState: Skipped synchronizing globalstate as it is running already.
[2021-04-25 06:20:25.672] [settingssync] [info] GlobalState: Skipped adding sync.store.url.type in local storage because it is declared as machine scoped.
[2021-04-25 06:20:25.696] [settingssync] [info] Extensions: Skipped synchronizing extensions as it is running already.
[2021-04-25 06:20:25.912] [settingssync] [info] Keybindings: Updated local keybindings
[2021-04-25 06:20:25.916] [settingssync] [info] Settings: Updated local settings
[2021-04-25 06:20:25.919] [settingssync] [info] Keybindings: Updated last synchronized keybindings
[2021-04-25 06:20:25.921] [settingssync] [info] Settings: Updated last synchronized settings
[2021-04-25 06:20:25.923] [settingssync] [info] Snippets: No changes found during synchronizing snippets.
[2021-04-25 06:20:25.929] [settingssync] [info] Snippets: Updated last synchronized snippets
[2021-04-25 06:20:25.951] [settingssync] [info] GlobalState: Updated locale.
[2021-04-25 06:20:25.951] [settingssync] [info] GlobalState: Updated locale
[2021-04-25 06:20:25.951] [settingssync] [info] GlobalState: Updated global state ["Comments.hidden","commandPalette.mru.cache","commandPalette.mru.counter","ctrlEnterReplaceAll.windows.donotask","expandSuggestionDocs","extensionTips/promptedExecutableTips","extensionsAssistant/importantRecommendationsIgnore","github-Tyriar","http.linkProtectionTrustedDomains","http.linkProtectionTrustedDomainsContent","memento/workbench.editor.keybindings","nps/isCandidate","nps/skipVersion","recently.opened","refactorPreview.hidden","remote.tunnels.toRestore.codespaces+tyriar-microsoft-vscode-ccvw.-2122825145","remote.tunnels.toRestore.codespaces+tyriar-xtermjs-xterm-js-gj2w.-1281495884","remote.tunnels.toRestore.codespaces+tyriar-xtermjs-xterm-js-hj66.-1281495884","remote.tunnels.toRestore.wsl+debian.1051598484",(snip),"terminal.integrated.showTerminalConfigPrompt","views.cachedViewContainerLocations","views.cachedViewPositions","workbench.panel.terminal.hidden","workbench.statusbar.hidden","workbench.view.extension.github-pull-request.state.hidden","workbench.view.extension.github-pull-requests.state.hidden","workbench.view.extension.gitlens.state.hidden","workbench.view.extension.jupyter-variables.state.hidden","workbench.view.extension.liveshare.state.hidden","workbench.view.extension.test.state.hidden","workbench.view.extensions.state.hidden","workbench.view.remote.state.hidden","workbench.view.sync.state.hidden","~remote.forwardedPorts.hidden",(snip),"workspace.trust.introduction.doNotShowAgain","workbench.views.service.panel.db75f626-4796-4fd4-92b9-fbdec9cb9f98.state.hidden","colorThemeData","cpp.1.lastSessionDate","cpp.1.sessionCount","java.2.lastSessionDate","java.2.sessionCount","javascript.1.lastSessionDate","javascript.1.sessionCount","memento/gettingStartedService","nps/lastSessionDate","nps/sessionCount","typescript.1.lastSessionDate","typescript.1.sessionCount","workbench.activity.pinnedViewlets2","workbench.explorer.views.state.hidden","workbench.panel.output.hidden","workbench.panel.pinnedPanels","workbench.scm.views.state.hidden","workbench.view.debug.state.hidden"]
[2021-04-25 06:20:25.951] [settingssync] [info] GlobalState: Updated local ui state
[2021-04-25 06:20:25.960] [settingssync] [info] GlobalState: Updated last synchronized ui state
[2021-04-25 06:20:26.133] [settingssync] [info] Extensions: Disabled extension ms-vscode.js-debug
[2021-04-25 06:20:26.173] [settingssync] [info] Extensions: Disabled extension ms-vscode.js-debug
[2021-04-25 06:20:26.236] [settingssync] [info] Extensions: Enabled extension dbaeumer.vscode-eslint 2.1.20
[2021-04-25 06:20:26.300] [settingssync] [info] Extensions: Enabled extension github.codespaces 0.9.4
[2021-04-25 06:20:26.303] [settingssync] [info] Extensions: Enabled extension github.github-vscode-theme 4.0.4
[2021-04-25 06:20:26.306] [settingssync] [info] Extensions: Enabled extension ms-toolsai.jupyter 2021.6.780948196
[2021-04-25 06:20:26.308] [settingssync] [info] Extensions: Enabled extension tyriar.theme-glacier 0.0.10
[2021-04-25 06:20:26.310] [settingssync] [info] Extensions: Enabled extension tyriar.luna-paint 0.4.0
[2021-04-25 06:20:26.312] [settingssync] [info] Extensions: Enabled extension hancel.markdown-image 1.1.8
[2021-04-25 06:20:26.314] [settingssync] [info] Extensions: Enabled extension github.github-vscode-theme 4.0.4
[2021-04-25 06:20:26.317] [settingssync] [info] Extensions: Enabled extension ms-vscode.vscode-selfhost-test-provider 0.2.0
[2021-04-25 06:20:26.319] [settingssync] [info] Extensions: Enabled extension slevesque.shader 1.1.5
[2021-04-25 06:20:26.321] [settingssync] [info] Extensions: Enabled extension tyriar.windows-terminal 0.6.0
[2021-04-25 06:20:26.324] [settingssync] [info] Extensions: Enabled extension ms-vscode-remote.remote-wsl 0.56.1
[2021-04-25 06:20:26.325] [settingssync] [info] Extensions: Enabled extension tyriar.sort-lines 1.9.0
[2021-04-25 06:20:26.330] [settingssync] [info] Extensions: Enabled extension pkief.material-icon-theme 4.6.0
[2021-04-25 06:20:26.331] [settingssync] [info] Extensions: Enabled extension ms-vscode-remote.remote-wsl 0.56.1
[2021-04-25 06:20:26.334] [settingssync] [info] Extensions: Enabled extension pkief.material-icon-theme 4.6.0
[2021-04-25 06:20:26.351] [settingssync] [info] Extensions: Enabled extension msjsdiag.debugger-for-edge 1.0.15
[2021-04-25 06:20:26.352] [settingssync] [info] Extensions: Enabled extension tyriar.sort-lines 1.9.0
[2021-04-25 06:20:26.356] [settingssync] [info] Extensions: Enabled extension tyriar.shell-launcher 0.4.1
[2021-04-25 06:20:26.402] [settingssync] [info] Extensions: Enabled extension tyriar.windows-terminal 0.6.0
[2021-04-25 06:20:26.403] [settingssync] [info] Extensions: Enabled extension ms-vscode.azurecli 0.5.0
[2021-04-25 06:20:26.405] [settingssync] [info] Extensions: Enabled extension ms-vscode.vscode-typescript-tslint-plugin 1.3.3
[2021-04-25 06:20:26.408] [settingssync] [info] Extensions: Enabled extension svipas.notification-tester 2.5.1
[2021-04-25 06:20:26.414] [settingssync] [info] Extensions: Enabled extension timonwong.shellcheck 0.14.1
[2021-04-25 06:20:26.447] [settingssync] [info] Extensions: Disabled extension eamodio.gitlens-insiders 2021.4.1805
[2021-04-25 06:20:26.470] [settingssync] [info] Extensions: Disabled extension eamodio.gitlens-insiders 2021.4.1805
[2021-04-25 06:20:26.496] [settingssync] [info] Extensions: Enabled extension tyriar.theme-sapphire 0.9.1
[2021-04-25 06:20:26.497] [settingssync] [info] Extensions: Enabled extension aeschli.vscode-css-formatter 1.0.1
[2021-04-25 06:20:26.498] [settingssync] [info] Extensions: Enabled extension ms-vscode.hexeditor 1.5.0
[2021-04-25 06:20:26.498] [settingssync] [info] Extensions: Enabled extension msjsdiag.debugger-for-edge 1.0.15
[2021-04-25 06:20:26.499] [settingssync] [info] Extensions: Enabled extension ms-vscode.hexeditor 1.5.0
[2021-04-25 06:20:26.499] [settingssync] [info] Extensions: Enabled extension aeschli.vscode-css-formatter 1.0.1
[2021-04-25 06:20:26.500] [settingssync] [info] Extensions: Enabled extension ms-vscode.azurecli 0.5.0
[2021-04-25 06:20:26.500] [settingssync] [info] Extensions: Enabled extension github.codespaces 0.9.4
[2021-04-25 06:20:26.513] [settingssync] [info] Extensions: Disabled extension geequlim.godot-tools 1.1.2
[2021-04-25 06:20:26.514] [settingssync] [info] Extensions: Disabled extension geequlim.godot-tools 1.1.2
[2021-04-25 06:20:26.514] [settingssync] [info] Extensions: Enabled extension meganrogge.template-string-converter 0.4.7
[2021-04-25 06:20:26.517] [settingssync] [info] Extensions: Enabled extension ms-vscode.vscode-selfhost-test-provider 0.2.0
[2021-04-25 06:20:26.517] [settingssync] [info] Extensions: Enabled extension slevesque.shader 1.1.5
[2021-04-25 06:20:26.517] [settingssync] [info] Extensions: Enabled extension ms-vscode.azure-account 0.9.8
[2021-04-25 06:20:26.518] [settingssync] [info] Extensions: Enabled extension ms-vscode.azure-account 0.9.8
[2021-04-25 06:20:26.518] [settingssync] [info] Extensions: Enabled extension editorconfig.editorconfig 0.16.4
[2021-04-25 06:20:26.519] [settingssync] [info] Extensions: Enabled extension wayou.vscode-todo-highlight 1.0.4
[2021-04-25 06:20:26.529] [settingssync] [info] Extensions: Enabled extension wayou.vscode-todo-highlight 1.0.4
[2021-04-25 06:20:26.534] [settingssync] [info] Extensions: Enabled extension cssho.vscode-svgviewer 2.0.0
[2021-04-25 06:20:26.536] [settingssync] [info] Extensions: Enabled extension tyriar.theme-topaz 0.1.2
[2021-04-25 06:20:26.538] [settingssync] [info] Extensions: Enabled extension tyriar.luna-paint 0.4.0
[2021-04-25 06:20:26.574] [settingssync] [info] Extensions: Enabled extension tyriar.theme-sapphire 0.9.1
[2021-04-25 06:20:26.575] [settingssync] [info] Extensions: Enabled extension tyriar.shell-launcher 0.4.1
[2021-04-25 06:20:26.576] [settingssync] [info] Extensions: Enabled extension tyriar.theme-glacier 0.0.10
[2021-04-25 06:20:26.577] [settingssync] [info] Extensions: Enabled extension cssho.vscode-svgviewer 2.0.0
[2021-04-25 06:20:26.578] [settingssync] [info] Extensions: Enabled extension tyriar.theme-topaz 0.1.2
[2021-04-25 06:20:26.585] [settingssync] [info] Extensions: Enabled extension meganrogge.template-string-converter 0.4.7
[2021-04-25 06:20:26.595] [settingssync] [info] Extensions: Enabled extension editorconfig.editorconfig 0.16.4
[2021-04-25 06:20:26.596] [settingssync] [info] Extensions: Enabled extension ms-vscode.vscode-typescript-tslint-plugin 1.3.3
[2021-04-25 06:20:26.598] [settingssync] [info] Extensions: Enabled extension svipas.notification-tester 2.5.1
[2021-04-25 06:20:26.601] [settingssync] [info] Extensions: Enabled extension timonwong.shellcheck 0.14.1
[2021-04-25 06:20:26.605] [settingssync] [info] Extensions: Enabled extension hancel.markdown-image 1.1.8
[2021-04-25 06:20:26.607] [settingssync] [info] Extensions: Enabled extension ms-toolsai.jupyter 2021.6.780948196
[2021-04-25 06:20:26.627] [settingssync] [info] Extensions: Enabled extension ms-vscode.vscode-github-issue-notebooks 0.0.85
[2021-04-25 06:20:26.632] [settingssync] [info] Extensions: Enabled extension ms-ceintl.vscode-language-pack-en-gb 1.54.1
[2021-04-25 06:20:26.636] [settingssync] [info] Extensions: Enabled extension dbaeumer.vscode-eslint 2.1.20
[2021-04-25 06:20:26.639] [settingssync] [info] Extensions: Enabled extension msjsdiag.debugger-for-chrome 4.12.12
[2021-04-25 06:20:26.641] [settingssync] [info] Extensions: Enabled extension ms-ceintl.vscode-language-pack-en-gb 1.54.1
[2021-04-25 06:20:26.645] [settingssync] [info] Extensions: Enabled extension msjsdiag.debugger-for-chrome 4.12.12
[2021-04-25 06:20:26.653] [settingssync] [info] Extensions: Enabled extension ms-vscode.vscode-github-issue-notebooks 0.0.85
[2021-04-25 06:20:26.674] [settingssync] [info] Extensions: Disabled extension ms-vscode-remote.remote-containers 0.171.0
[2021-04-25 06:20:26.681] [settingssync] [info] Extensions: Disabled extension ms-vscode-remote.remote-containers 0.171.0
[2021-04-25 06:20:26.695] [settingssync] [info] Extensions: Enabled extension ms-vsliveshare.vsliveshare 1.0.4131
[2021-04-25 06:20:26.700] [settingssync] [info] Extensions: Enabled extension ms-vsliveshare.vsliveshare 1.0.4131
[2021-04-25 06:20:26.713] [settingssync] [info] Extensions: Enabled extension ms-vscode.js-debug-nightly 2021.4.2317
[2021-04-25 06:20:26.718] [settingssync] [info] Extensions: Enabled extension ms-vscode.js-debug-nightly 2021.4.2317
[2021-04-25 06:20:26.728] [settingssync] [info] Extensions: Enabled extension ms-vscode-remote.remote-ssh-edit-nightly 2021.4.29700
[2021-04-25 06:20:26.738] [settingssync] [info] Extensions: Enabled extension ms-vscode-remote.remote-ssh-edit-nightly 2021.4.29700
[2021-04-25 06:20:26.744] [settingssync] [info] Extensions: Enabled extension ms-vscode-remote.remote-ssh-nightly 2021.4.29700
[2021-04-25 06:20:26.753] [settingssync] [info] Extensions: Enabled extension ms-vscode-remote.remote-ssh-nightly 2021.4.29700
[2021-04-25 06:20:26.871] [settingssync] [info] Extensions: Enabled extension github.vscode-pull-request-github-insiders 2021.4.30783
[2021-04-25 06:20:26.882] [settingssync] [info] Extensions: Enabled extension github.vscode-pull-request-github-insiders 2021.4.30783
[2021-04-25 06:20:27.421] [settingssync] [info] Extensions: Installed extension. svipas.notification-tester 2.5.1
[2021-04-25 06:20:27.422] [settingssync] [info] Extensions: Installed extension. svipas.notification-tester 2.5.1
[2021-04-25 06:20:27.433] [settingssync] [info] Extensions: Installed extension. tyriar.theme-glacier 0.0.10
[2021-04-25 06:20:27.433] [settingssync] [info] Extensions: Installed extension. tyriar.theme-glacier 0.0.10
[2021-04-25 06:20:27.488] [settingssync] [info] Extensions: Installed extension. tyriar.shell-launcher 0.4.1
[2021-04-25 06:20:27.489] [settingssync] [info] Extensions: Installed extension. tyriar.shell-launcher 0.4.1
[2021-04-25 06:20:27.557] [settingssync] [info] Extensions: Installed extension. github.github-vscode-theme 4.0.4
[2021-04-25 06:20:27.557] [settingssync] [info] Extensions: Installed extension. github.github-vscode-theme 4.0.4
[2021-04-25 06:20:27.564] [settingssync] [info] Extensions: Installed extension. dbaeumer.vscode-eslint 2.1.20
[2021-04-25 06:20:27.564] [settingssync] [info] Extensions: Installed extension. dbaeumer.vscode-eslint 2.1.20
[2021-04-25 06:20:27.649] [settingssync] [info] Extensions: Installed extension. tyriar.windows-terminal 0.6.0
[2021-04-25 06:20:27.649] [settingssync] [info] Extensions: Installed extension. tyriar.windows-terminal 0.6.0
[2021-04-25 06:20:27.676] [settingssync] [info] Extensions: Installed extension. ms-vscode-remote.remote-wsl 0.56.1
[2021-04-25 06:20:27.677] [settingssync] [info] Extensions: Installed extension. ms-vscode-remote.remote-wsl 0.56.1
[2021-04-25 06:20:27.830] [settingssync] [info] Extensions: Installed extension. tyriar.sort-lines 1.9.0
[2021-04-25 06:20:27.830] [settingssync] [info] Extensions: Installed extension. tyriar.sort-lines 1.9.0
[2021-04-25 06:20:27.866] [settingssync] [info] Extensions: Installed extension. tyriar.luna-paint 0.4.0
[2021-04-25 06:20:27.866] [settingssync] [info] Extensions: Installed extension. tyriar.luna-paint 0.4.0
[2021-04-25 06:20:28.077] [settingssync] [info] Extensions: Installed extension. meganrogge.template-string-converter 0.4.7
[2021-04-25 06:20:28.077] [settingssync] [info] Extensions: Installed extension. meganrogge.template-string-converter 0.4.7
[2021-04-25 06:20:28.114] [settingssync] [info] Extensions: Installed extension. ms-vscode.vscode-typescript-tslint-plugin 1.3.3
[2021-04-25 06:20:28.114] [settingssync] [info] Extensions: Installed extension. ms-vscode.vscode-typescript-tslint-plugin 1.3.3
[2021-04-25 06:20:28.379] [settingssync] [info] Extensions: Installed extension. ms-vscode-remote.remote-ssh-edit-nightly 2021.4.29700
[2021-04-25 06:20:28.379] [settingssync] [info] Extensions: Installed extension. ms-vscode-remote.remote-ssh-edit-nightly 2021.4.29700
[2021-04-25 06:20:28.638] [settingssync] [info] Extensions: Installed extension. editorconfig.editorconfig 0.16.4
[2021-04-25 06:20:28.638] [settingssync] [info] Extensions: Installed extension. editorconfig.editorconfig 0.16.4
[2021-04-25 06:20:29.195] [settingssync] [info] Extensions: Installed extension. pkief.material-icon-theme 4.6.0
[2021-04-25 06:20:29.195] [settingssync] [info] Extensions: Installed extension. pkief.material-icon-theme 4.6.0
[2021-04-25 06:20:29.461] [settingssync] [info] Extensions: Installed extension. ms-vscode.azure-account 0.9.8
[2021-04-25 06:20:29.461] [settingssync] [info] Extensions: Installed extension. ms-vscode.azure-account 0.9.8
[2021-04-25 06:20:29.801] [settingssync] [info] Extensions: Installed extension. aeschli.vscode-css-formatter 1.0.1
[2021-04-25 06:20:29.801] [settingssync] [info] Extensions: Installed extension. aeschli.vscode-css-formatter 1.0.1
[2021-04-25 06:20:30.351] [settingssync] [info] Extensions: Installed extension. github.vscode-pull-request-github-insiders 2021.4.30783
[2021-04-25 06:20:30.351] [settingssync] [info] Extensions: Installed extension. github.vscode-pull-request-github-insiders 2021.4.30783
[2021-04-25 06:20:30.811] [settingssync] [info] Extensions: Installed extension. ms-vscode-remote.remote-ssh-nightly 2021.4.29700
[2021-04-25 06:20:30.811] [settingssync] [info] Extensions: Installed extension. ms-vscode-remote.remote-ssh-nightly 2021.4.29700
[2021-04-25 06:20:30.892] [settingssync] [info] Extensions: Installed extension. ms-vscode.hexeditor 1.5.0
[2021-04-25 06:20:30.892] [settingssync] [info] Extensions: Installed extension. ms-vscode.hexeditor 1.5.0
[2021-04-25 06:20:31.176] [settingssync] [info] Extensions: Installed extension. ms-ceintl.vscode-language-pack-en-gb 1.54.1
[2021-04-25 06:20:31.177] [settingssync] [info] Extensions: Installed extension. ms-ceintl.vscode-language-pack-en-gb 1.54.1
[2021-04-25 06:20:31.455] [settingssync] [info] Extensions: Installed extension. ms-vscode.vscode-github-issue-notebooks 0.0.85
[2021-04-25 06:20:31.455] [settingssync] [info] Extensions: Installed extension. ms-vscode.vscode-github-issue-notebooks 0.0.85
[2021-04-25 06:20:31.545] [settingssync] [info] Extensions: Installed extension. wayou.vscode-todo-highlight 1.0.4
[2021-04-25 06:20:31.546] [settingssync] [info] Extensions: Installed extension. wayou.vscode-todo-highlight 1.0.4
[2021-04-25 06:20:31.763] [settingssync] [info] Extensions: Installed extension. tyriar.theme-sapphire 0.9.1
[2021-04-25 06:20:31.763] [settingssync] [info] Extensions: Installed extension. tyriar.theme-sapphire 0.9.1
[2021-04-25 06:20:31.996] [settingssync] [info] Extensions: Installed extension. tyriar.theme-topaz 0.1.2
[2021-04-25 06:20:31.996] [settingssync] [info] Extensions: Installed extension. tyriar.theme-topaz 0.1.2
[2021-04-25 06:20:32.384] [settingssync] [info] Extensions: Installed extension. ms-vscode.js-debug-nightly 2021.4.2317
[2021-04-25 06:20:32.384] [settingssync] [info] Extensions: Installed extension. ms-vscode.js-debug-nightly 2021.4.2317
[2021-04-25 06:20:33.709] [settingssync] [info] Extensions: Installed extension. ms-vscode-remote.remote-containers 0.171.0
[2021-04-25 06:20:33.709] [settingssync] [info] Extensions: Installed extension. ms-vscode-remote.remote-containers 0.171.0
[2021-04-25 06:20:33.985] [settingssync] [info] Extensions: Installed extension. eamodio.gitlens-insiders 2021.4.1805
[2021-04-25 06:20:33.985] [settingssync] [info] Extensions: Installed extension. eamodio.gitlens-insiders 2021.4.1805
[2021-04-25 06:20:34.541] [settingssync] [info] Extensions: Installed extension. ms-toolsai.jupyter 2021.6.780948196
[2021-04-25 06:20:34.541] [settingssync] [info] Extensions: Installed extension. ms-toolsai.jupyter 2021.6.780948196
[2021-04-25 06:20:34.590] [settingssync] [info] Extensions: Installed extension. ms-vscode.azurecli 0.5.0
[2021-04-25 06:20:34.590] [settingssync] [info] Extensions: Installed extension. ms-vscode.azurecli 0.5.0
[2021-04-25 06:20:34.672] [settingssync] [info] Extensions: Installed extension. msjsdiag.debugger-for-chrome 4.12.12
[2021-04-25 06:20:34.673] [settingssync] [info] Extensions: Installed extension. msjsdiag.debugger-for-chrome 4.12.12
[2021-04-25 06:20:34.699] [settingssync] [info] Extensions: Installed extension. github.codespaces 0.9.4
[2021-04-25 06:20:34.699] [settingssync] [info] Extensions: Installed extension. github.codespaces 0.9.4
[2021-04-25 06:20:35.001] [settingssync] [info] Extensions: Installed extension. geequlim.godot-tools 1.1.2
[2021-04-25 06:20:35.001] [settingssync] [info] Extensions: Installed extension. geequlim.godot-tools 1.1.2
[2021-04-25 06:20:36.642] [settingssync] [info] Extensions: Installed extension. ms-vscode.vscode-selfhost-test-provider 0.2.0
[2021-04-25 06:20:36.642] [settingssync] [info] Extensions: Installed extension. ms-vscode.vscode-selfhost-test-provider 0.2.0
[2021-04-25 06:20:37.723] [settingssync] [info] Extensions: Installed extension. hancel.markdown-image 1.1.8
[2021-04-25 06:20:37.723] [settingssync] [info] Extensions: Installed extension. hancel.markdown-image 1.1.8
[2021-04-25 06:20:38.291] [settingssync] [info] Extensions: Installed extension. timonwong.shellcheck 0.14.1
[2021-04-25 06:20:38.291] [settingssync] [info] Extensions: Installed extension. timonwong.shellcheck 0.14.1
[2021-04-25 06:20:38.392] [settingssync] [info] Extensions: Installed extension. msjsdiag.debugger-for-edge 1.0.15
[2021-04-25 06:20:38.392] [settingssync] [info] Extensions: Installed extension. msjsdiag.debugger-for-edge 1.0.15
[2021-04-25 06:20:39.075] [settingssync] [info] Extensions: Installed extension. ms-vsliveshare.vsliveshare 1.0.4131
[2021-04-25 06:20:39.075] [settingssync] [info] Extensions: Installed extension. ms-vsliveshare.vsliveshare 1.0.4131
[2021-04-25 06:20:40.152] [settingssync] [info] Extensions: Installed extension. slevesque.shader 1.1.5
[2021-04-25 06:20:40.152] [settingssync] [info] Extensions: Installed extension. slevesque.shader 1.1.5
[2021-04-25 06:20:40.175] [settingssync] [info] Extensions: Installed extension. cssho.vscode-svgviewer 2.0.0
[2021-04-25 06:20:40.175] [settingssync] [info] Extensions: Installed extension. cssho.vscode-svgviewer 2.0.0
[2021-04-25 06:20:40.254] [settingssync] [info] Extensions: Updated remote extensions
[2021-04-25 06:20:40.257] [settingssync] [info] Extensions: Updated last synchronized extensions
[2021-04-25 06:20:40.272] [settingssync] [info] Auto Sync: Started
[2021-04-25 06:20:40.272] [settingssync] [info] Auto Sync: Triggered by Interval
[2021-04-25 06:20:40.394] [settingssync] [info] Settings: No changes found during synchronizing settings.
[2021-04-25 06:20:40.413] [settingssync] [info] Keybindings: Detected conflicts while synchronizing keybindings.
[2021-04-25 06:20:40.415] [settingssync] [info] Snippets: No changes found during synchronizing snippets.
[2021-04-25 06:20:40.545] [settingssync] [info] GlobalState: Updated remote ui state
[2021-04-25 06:20:40.549] [settingssync] [info] GlobalState: Updated last synchronized ui state
[2021-04-25 06:20:40.695] [settingssync] [info] Extensions: No changes found during synchronizing extensions.
[2021-04-25 06:20:40.701] [settingssync] [info] Sync done. Took 372ms
[2021-04-25 06:20:41.277] [settingssync] [info] Extensions: Updated remote extensions
[2021-04-25 06:20:41.280] [settingssync] [info] Extensions: Updated last synchronized extensions
[2021-04-25 06:20:43.496] [settingssync] [info] Auto Sync: Triggered by Activity
[2021-04-25 06:20:43.565] [settingssync] [info] Settings: No changes found during synchronizing settings.
[2021-04-25 06:20:43.568] [settingssync] [info] Keybindings: Skipped synchronizing keybindings as there are conflicts.
[2021-04-25 06:20:43.570] [settingssync] [info] Snippets: No changes found during synchronizing snippets.
[2021-04-25 06:20:43.648] [settingssync] [info] Request failed {"url":"https://vscode-sync-insiders.trafficmanager.net/v1/resource/globalState","status":412,"execution-id":"bddb8b96-d3dc-4559-930d-fb28d7ec9a2c","operation-id":"0be9cce7c50143f283efca60a681581c"}
[2021-04-25 06:20:43.648] [settingssync] [info] GlobalState: Failed to synchronize as there is a new remote version available. Synchronizing again...
[2021-04-25 06:20:43.713] [settingssync] [info] GlobalState: Updated global state ["colorThemeData","workbench.panel.pinnedPanels","workbench.view.remote.state.hidden"]
[2021-04-25 06:20:43.713] [settingssync] [info] GlobalState: Updated local ui state
[2021-04-25 06:20:43.817] [settingssync] [info] GlobalState: Updated remote ui state
[2021-04-25 06:20:43.820] [settingssync] [info] GlobalState: Updated last synchronized ui state
[2021-04-25 06:20:43.960] [settingssync] [info] Extensions: No changes found during synchronizing extensions.
[2021-04-25 06:20:43.961] [settingssync] [info] Sync done. Took 424ms
[2021-04-25 06:20:47.171] [settingssync] [info] Auto Sync: Triggered by Activity
[2021-04-25 06:20:47.242] [settingssync] [info] Settings: No changes found during synchronizing settings.
[2021-04-25 06:20:47.244] [settingssync] [info] Keybindings: Skipped synchronizing keybindings as there are conflicts.
[2021-04-25 06:20:47.246] [settingssync] [info] Snippets: No changes found during synchronizing snippets.
[2021-04-25 06:20:47.382] [settingssync] [info] GlobalState: Updated remote ui state
[2021-04-25 06:20:47.386] [settingssync] [info] GlobalState: Updated last synchronized ui state
[2021-04-25 06:20:47.485] [settingssync] [info] Extensions: No changes found during synchronizing extensions.
[2021-04-25 06:20:47.485] [settingssync] [info] Sync done. Took 270ms
[2021-04-25 06:21:05.809] [settingssync] [info] Auto Sync: Triggered by Activity
[2021-04-25 06:21:05.909] [settingssync] [info] Settings: No changes found during synchronizing settings.
[2021-04-25 06:21:05.912] [settingssync] [info] Keybindings: Skipped synchronizing keybindings as there are conflicts.
[2021-04-25 06:21:05.915] [settingssync] [info] Snippets: No changes found during synchronizing snippets.
[2021-04-25 06:21:05.951] [settingssync] [info] GlobalState: No changes found during synchronizing ui state.
[2021-04-25 06:21:06.055] [settingssync] [info] Extensions: No changes found during synchronizing extensions.
[2021-04-25 06:21:06.056] [settingssync] [info] Sync done. Took 188ms
[2021-04-25 06:21:31.528] [settingssync] [info] Auto Sync: Triggered by Activity
[2021-04-25 06:21:31.644] [settingssync] [info] Settings: No changes found during synchronizing settings.
[2021-04-25 06:21:31.645] [settingssync] [info] Keybindings: Skipped synchronizing keybindings as there are conflicts.
[2021-04-25 06:21:31.646] [settingssync] [info] Snippets: No changes found during synchronizing snippets.
[2021-04-25 06:21:31.791] [settingssync] [info] GlobalState: Updated remote ui state
[2021-04-25 06:21:31.794] [settingssync] [info] GlobalState: Updated last synchronized ui state
[2021-04-25 06:21:31.911] [settingssync] [info] Extensions: No changes found during synchronizing extensions.
[2021-04-25 06:21:31.911] [settingssync] [info] Sync done. Took 330ms
[2021-04-25 06:23:41.310] [settingssync] [info] Auto Sync: Triggered by Activity
[2021-04-25 06:23:41.655] [settingssync] [info] Settings: No changes found during synchronizing settings.
[2021-04-25 06:23:41.656] [settingssync] [info] Keybindings: Skipped synchronizing keybindings as there are conflicts.
[2021-04-25 06:23:41.659] [settingssync] [info] Snippets: No changes found during synchronizing snippets.
[2021-04-25 06:23:41.692] [settingssync] [info] GlobalState: No changes found during synchronizing ui state.
[2021-04-25 06:23:41.799] [settingssync] [info] Extensions: No changes found during synchronizing extensions.
[2021-04-25 06:23:41.800] [settingssync] [info] Sync done. Took 177ms
[2021-04-25 06:25:06.599] [settingssync] [info] Auto Sync: Triggered by Activity
[2021-04-25 06:25:06.704] [settingssync] [info] Settings: No changes found during synchronizing settings.
[2021-04-25 06:25:06.705] [settingssync] [info] Keybindings: Skipped synchronizing keybindings as there are conflicts.
[2021-04-25 06:25:06.707] [settingssync] [info] Snippets: No changes found during synchronizing snippets.
[2021-04-25 06:25:06.738] [settingssync] [info] GlobalState: No changes found during synchronizing ui state.
[2021-04-25 06:25:06.834] [settingssync] [info] Extensions: No changes found during synchronizing extensions.
[2021-04-25 06:25:06.835] [settingssync] [info] Sync done. Took 178ms
[2021-04-25 06:25:26.049] [settingssync] [info] Auto Sync: Triggered by Activity
[2021-04-25 06:25:26.162] [settingssync] [info] Settings: No changes found during synchronizing settings.
[2021-04-25 06:25:26.163] [settingssync] [info] Keybindings: Skipped synchronizing keybindings as there are conflicts.
[2021-04-25 06:25:26.165] [settingssync] [info] Snippets: No changes found during synchronizing snippets.
[2021-04-25 06:25:26.293] [settingssync] [info] GlobalState: Updated remote ui state
[2021-04-25 06:25:26.303] [settingssync] [info] GlobalState: Updated last synchronized ui state
[2021-04-25 06:25:26.447] [settingssync] [info] Extensions: No changes found during synchronizing extensions.
[2021-04-25 06:25:26.448] [settingssync] [info] Sync done. Took 355ms
[2021-04-25 06:27:25.531] [settingssync] [info] Auto Sync: Triggered by Activity
[2021-04-25 06:27:25.659] [settingssync] [info] Settings: No changes found during synchronizing settings.
[2021-04-25 06:27:25.664] [settingssync] [info] Keybindings: Skipped synchronizing keybindings as there are conflicts.
[2021-04-25 06:27:25.666] [settingssync] [info] Snippets: No changes found during synchronizing snippets.
[2021-04-25 06:27:25.696] [settingssync] [info] GlobalState: No changes found during synchronizing ui state.
[2021-04-25 06:27:25.788] [settingssync] [info] Extensions: No changes found during synchronizing extensions.
[2021-04-25 06:27:25.789] [settingssync] [info] Sync done. Took 195ms
[2021-04-25 06:28:18.285] [settingssync] [info] Auto Sync: Triggered by Activity
[2021-04-25 06:28:18.378] [settingssync] [info] Settings: No changes found during synchronizing settings.
[2021-04-25 06:28:18.379] [settingssync] [info] Keybindings: Skipped synchronizing keybindings as there are conflicts.
[2021-04-25 06:28:18.381] [settingssync] [info] Snippets: No changes found during synchronizing snippets.
[2021-04-25 06:28:18.411] [settingssync] [info] GlobalState: No changes found during synchronizing ui state.
[2021-04-25 06:28:18.513] [settingssync] [info] Extensions: No changes found during synchronizing extensions.
[2021-04-25 06:28:18.514] [settingssync] [info] Sync done. Took 184ms
@sandy081 sandy081 added this to the May 2021 milestone Apr 27, 2021
@sandy081
Copy link
Member

I assume the root cause is that sync is happening twice - may I know how you get into that situation - Firstly I hit a vscode-auth.github.com error which told me to restart the install flow (I think this is a known issue as I've hit it before). ?

@Tyriar
Copy link
Member Author

Tyriar commented Apr 27, 2021

I tried to sign in and got to an error, so I never got the dialog to open the uri handler in vscode and needed to restart. VS Code should not have started because of that, it couldn't auth to the server.

@sandy081
Copy link
Member

Are you saying that sync happened even when auth is failed?

@Tyriar
Copy link
Member Author

Tyriar commented Apr 28, 2021

No, it couldn't do that because vscode didn't have a token

@sandy081
Copy link
Member

Ok. Then I am sorry that I do not understand how the sync started twice. Can you please help me how this happened?

@Tyriar
Copy link
Member Author

Tyriar commented Apr 28, 2021

Was pretty detailed above on the repro. Perhaps it's related to a new data dir or the auth flow queuing up a sync but it doesn't get removed when it fails?

@sandy081
Copy link
Member

I am sorry that it was not clear to me in the description. So your steps were as follows (please correct me if I am wrong) ?

  • On a brand new machine, you opened VS Code insiders
  • Turned on Settings sync which triggered the auth
  • You got an error from Auth Firstly I hit a vscode-auth.github.com error which told me to restart the install flow (I think this is a known issue as I've hit it before).
  • You restarted VS Code as you said it asked you to restart?
  • Turned on Settings Sync again?

Now you see two syncs happening?

@Tyriar
Copy link
Member Author

Tyriar commented May 3, 2021

You restarted VS Code as you said it asked you to restart?

I didn't restart vs code, just tried to re-enable setting sync after it failed.

@sandy081 sandy081 modified the milestones: May 2021, June 2021 Jun 3, 2021
@sandy081 sandy081 removed this from the June 2021 milestone Jun 30, 2021
@sandy081 sandy081 changed the title Bad experience enabling settings sync on new machine Delay restart prompt while settings sync is turning on Dec 7, 2022
@sandy081 sandy081 added the bug Issue identified by VS Code Team member as probable bug label Dec 7, 2022
@sandy081 sandy081 added this to the Backlog milestone Dec 7, 2022
@sandy081
Copy link
Member

sandy081 commented Dec 7, 2022

It seems there are many issues reported here and some of them are not clear. Hence I changed this issue to tackle restarting because of setting change while turning on. There is also issue for language packs - #104124

@Tyriar Please file different issue for each scenario with necessary info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug settings-sync
Projects
None yet
Development

No branches or pull requests

2 participants