-
Notifications
You must be signed in to change notification settings - Fork 27.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delay restart prompt while settings sync is turning on #122132
Comments
I assume the root cause is that sync is happening twice - may I know how you get into that situation - |
I tried to sign in and got to an error, so I never got the dialog to open the uri handler in vscode and needed to restart. VS Code should not have started because of that, it couldn't auth to the server. |
Are you saying that sync happened even when auth is failed? |
No, it couldn't do that because vscode didn't have a token |
Ok. Then I am sorry that I do not understand how the sync started twice. Can you please help me how this happened? |
Was pretty detailed above on the repro. Perhaps it's related to a new data dir or the auth flow queuing up a sync but it doesn't get removed when it fails? |
I am sorry that it was not clear to me in the description. So your steps were as follows (please correct me if I am wrong) ?
Now you see two syncs happening? |
I didn't restart vs code, just tried to re-enable setting sync after it failed. |
I just reinstalled Windows on a larger SSD and didn't have the greatest experience enabling setting sync.
Firstly I hit a
vscode-auth.github.com
error which told me to restart the install flow (I think this is a known issue as I've hit it before).Then I got 2 sync progress notifications for some reason and got told to restart immediately after auth went through (which would stop the sync process):
Then I got a merge conflict issue which is weird because I literally just installed Insiders on a branch new machine:
After pressing cancel I was told to merge manually:
The merges view showed up, but didn't present anything to merge:
Pressing turn on settings sync then turned it on 🤷♂️
Restarting presented the keybinding conflict notification which showed the following conflicts:
Action items:
scm/input:Git:/
paths being synced in settings sync? They're local to the machine and also contain somewhat sensitive information. I needed to manually review the log before pasting in an issue, here's a snippet:"scm/input:Git:/Users/daimms/dev/Microsoft/node-pty","scm/input:Git:/Users/daimms/dev/Microsoft/vscode"
. Can we mark these keys as sensitive to avoid pasting into bug reports and/or needing the user to hand sanitize?Log:
The text was updated successfully, but these errors were encountered: