Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Resolving conversations in GHPRI #122243

Closed
3 tasks done
RMacfarlane opened this issue Apr 26, 2021 · 1 comment
Closed
3 tasks done

Test: Resolving conversations in GHPRI #122243

RMacfarlane opened this issue Apr 26, 2021 · 1 comment

Comments

@RMacfarlane
Copy link
Contributor

RMacfarlane commented Apr 26, 2021

Refs: microsoft/vscode-pull-request-github#339

Complexity: 3

Create Issue


Please use the nightly version of the GitHub Pull Requests and Issues extension to test.

There is now a "Resolve conversation" button that appears on comment threads within editors. This should:

  • Mark the thread as resolved on GitHub (note that you cannot resolve threads that are on pending reviews)
  • Collapse the comment widget in the VS Code editor after resolving, and on future opens of the file (unless you expand it again)
  • Update the comment thread title to say the thread has been resolved
  • Show an "Unresolved conversation" button on comments that have been resolved
@roblourens
Copy link
Member

I think I am blocked by https://github.com/microsoft/vscode-pull-request-github/issues/2684. I have this issue in multiple test repos. I can open files in PRs in the vscode repo, but I don't want to test this feature on a real repo.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants