Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

White space appears below status bar on iPad PWA mode #122390

Closed
miguelsolorio opened this issue Apr 27, 2021 · 7 comments
Closed

White space appears below status bar on iPad PWA mode #122390

miguelsolorio opened this issue Apr 27, 2021 · 7 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders ios-ipados verified Verification succeeded
Milestone

Comments

@miguelsolorio
Copy link
Contributor

miguelsolorio commented Apr 27, 2021

image

When you add VS Code to the home screen (similar to PWA) you get this nice full-screen mode that removes the top Safari chrome. However there are two issues that come up:

1. Login sessions are not persisted and you have to re-login
2. After logging in there is a white gap at the bottom

@miguelsolorio miguelsolorio added bug Issue identified by VS Code Team member as probable bug ios-ipados labels Apr 27, 2021
@miguelsolorio
Copy link
Contributor Author

@bpasero would this fall under your area?

@alexdima
Copy link
Member

I think the login session (1.) is not under our control, but the gap at the bottom might very well be from us.

@bpasero
Copy link
Member

bpasero commented Apr 28, 2021

//cc @rebornix

@isidorn
Copy link
Contributor

isidorn commented Apr 28, 2021

Assigning to May to investigate then. Also assigning to @rebornix
Somewhat similar issue regarding whitespace #121206

@isidorn isidorn added this to the May 2021 milestone Apr 28, 2021
@rebornix
Copy link
Member

rebornix commented Apr 28, 2021

it's this fancy code ;(

browser.isStandalone
// in PWA mode, the visual viewport always includes the safe-area-inset-bottom (which is for the home indicator)
// even when you are using the onscreen monitor, the visual viewport will include the area between system statusbar and the onscreen keyboard
// plus the area between onscreen keyboard and the bottom bezel, which is 20px on iOS.
? (20 + 4) // + 4px for body margin
: 0

@miguelsolorio miguelsolorio changed the title Better PWA support on iPad White space appears below status bar on iPad PWA mode Apr 28, 2021
@isidorn
Copy link
Contributor

isidorn commented Apr 28, 2021

@rebornix thanks a lot for the pointer, I will look into this in debt week

@isidorn
Copy link
Contributor

isidorn commented May 7, 2021

Just removing that extra code solves the issue. @rebornix thanks again for the pointer
Now the status bar might overlap with the ipad home indicator, which I think is actually a great experience most of the time.

@bpasero bpasero added the verified Verification succeeded label Jun 4, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jun 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders ios-ipados verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

6 participants
@rebornix @bpasero @isidorn @alexdima @miguelsolorio and others