Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Menu migration #122599

Merged
merged 9 commits into from
May 3, 2021
Merged

Menu migration #122599

merged 9 commits into from
May 3, 2021

Conversation

meganrogge
Copy link
Contributor

@meganrogge meganrogge commented Apr 28, 2021 •
edited

This PR fixes #122037

@meganrogge meganrogge self-assigned this Apr 28, 2021
@meganrogge meganrogge added this to the May 2021 milestone Apr 28, 2021
@meganrogge meganrogge requested a review from Tyriar April 29, 2021 02:55
Tyriar
Tyriar approved these changes May 3, 2021
View reviewed changes
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't test but lgtm if those are resolved

@meganrogge meganrogge enabled auto-merge (squash) May 3, 2021 13:38
@meganrogge meganrogge merged commit 5bf5c77 into main May 3, 2021
@meganrogge meganrogge deleted the merogge/menuMigration branch May 3, 2021 13:51
@github-actions github-actions bot locked and limited conversation to collaborators Jun 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Tyriar Tyriar Tyriar approved these changes

Assignees

@meganrogge meganrogge

Labels
None yet
Projects
None yet
Milestone
May 2021
Development

Successfully merging this pull request may close these issues.

Terminal: Split menu registration out from actions
2 participants
@meganrogge @Tyriar