New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix#122454: Truncate the long terminal title #122620
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does work correctly, for me this is approved
@aeschli thoughts on the changes to iconLabels? Should we make this span the baseline behavior instead? |
I don't like the changes to iconLabels very much: I'd suggest to keep the changes local to the terminal title and not try to generalize this already in the iconLabels.
I see that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aeschli |
This reverts commit 821e1e5.
This got reverted in #128483 |
This PR fixes #122454