Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block windows/iframes from preventing the unload #122835

Merged
merged 3 commits into from May 3, 2021
Merged

Block windows/iframes from preventing the unload #122835

merged 3 commits into from May 3, 2021

Conversation

bpasero
Copy link
Member

@bpasero bpasero commented May 3, 2021

An imho better fix for #122736

//cc @deepak1556

@bpasero bpasero added this to the May 2021 milestone May 3, 2021
@bpasero bpasero requested a review from mjbvz May 3, 2021 08:14
@bpasero bpasero self-assigned this May 3, 2021
deepak1556
deepak1556 approved these changes May 3, 2021
View reviewed changes
Copy link
Contributor

@deepak1556 deepak1556 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mjbvz
Copy link
Contributor

mjbvz commented May 3, 2021

Thanks @bpasero! Merging this for testing. Seems like a less risky fix that my hack so we should consider taking this into 1.56

@mjbvz mjbvz merged commit 62736de into main May 3, 2021
@mjbvz mjbvz deleted the ben/disable-unload-prevent branch May 3, 2021 16:57
mjbvz pushed a commit to mjbvz/vscode that referenced this pull request May 3, 2021
@bpasero @mjbvz
Block windows/iframes from preventing the unload (microsoft#122835)
5a8170c 
* Revert "Only disable onbeforeunload if using iframe based webviews"

This reverts commit dfb22d1.

* Revert "Try to block webviews from cancelling unloads"

This reverts commit dee149a.

* prevent a window or iframe to block the unload
@mjbvz mjbvz mentioned this pull request May 3, 2021
Merged
mjbvz added a commit that referenced this pull request May 3, 2021
@mjbvz @bpasero
Block windows/iframes from preventing the unload (#122835) (#122869)
5913f53 
* Revert "Only disable onbeforeunload if using iframe based webviews"

This reverts commit dfb22d1.

* Revert "Try to block webviews from cancelling unloads"

This reverts commit dee149a.

* prevent a window or iframe to block the unload

Co-authored-by: Benjamin Pasero <benjpas@microsoft.com>
@github-actions github-actions bot locked and limited conversation to collaborators Jun 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@deepak1556 deepak1556 deepak1556 approved these changes

@mjbvz mjbvz Awaiting requested review from mjbvz

Assignees

@bpasero bpasero

Labels
None yet
Projects
None yet
Milestone
May 2021
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bpasero @mjbvz @deepak1556