Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

externalTerminal renderer -> main process #122871

Merged
merged 13 commits into from May 4, 2021
Merged

externalTerminal renderer -> main process #122871

merged 13 commits into from May 4, 2021

Conversation

meganrogge
Copy link
Contributor

This PR fixes #118405

@meganrogge meganrogge requested a review from Tyriar May 3, 2021 21:35
@meganrogge meganrogge added this to the May 2021 milestone May 3, 2021
@meganrogge meganrogge changed the title externalTerminal node -> main externalTerminal renderer -> main process May 3, 2021
@meganrogge meganrogge requested a review from Tyriar May 3, 2021 22:16
@meganrogge meganrogge enabled auto-merge (squash) May 4, 2021 02:05
@meganrogge meganrogge merged commit de4e906 into main May 4, 2021
@meganrogge meganrogge deleted the merogge/sandbox branch May 4, 2021 02:18
@github-actions github-actions bot locked and limited conversation to collaborators Jun 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sandbox: move externalTerminal.contribution to a better place
2 participants