Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolbar cell commands do not get current cell but get the selected cell as an argument #123002

Closed
DonJayamanne opened this issue May 5, 2021 · 2 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug notebook

Comments

@DonJayamanne
Copy link
Contributor

  • VS Code Version: Insiders
  • OS Version: Mac

Steps to Reproduce:

  1. Create a notebook extension
  2. Add a cell toolbar and wire up a command
  3. Create a notebook with 2 cells
  4. Select the second cell
  5. CLick the toolbar button on the first cell
  6. The command gets the second cell (because second cell is selected).

@rebornix I think you fixed this for split or some others, however i believe it was only fixed for VS Code Core commands. Looks like the commands are not getting the right cell in extensions as well.

Does this issue occur when all extensions are disabled?: Yes/No

@DonJayamanne
Copy link
Contributor Author

Apologies bug at my end.

@rzhao271 rzhao271 removed this from the May 2021 milestone Jun 3, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jun 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug notebook
Projects
None yet
Development

No branches or pull requests

5 participants
@roblourens @rebornix @DonJayamanne @rzhao271 and others