Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix keybindings title #123071

Merged
merged 6 commits into from
Nov 18, 2021
Merged

Fix keybindings title #123071

merged 6 commits into from
Nov 18, 2021

Conversation

Pranomvignesh
Copy link
Contributor

This PR fixes issue in monaco-editor#2468

Description :

  • I have changed the value of altKey in AriaLabelProvider in the file keybindingLabels.ts

Testing :

  • I hovered over the shortcut binding inside the quick input command palette and that is now properly showing as Option

@Pranomvignesh
Copy link
Contributor Author

@alexdima Are Contributors allowed to refactor the test files? As I can see that most of the assertions failed because it is expecting an improper value

For example :
One test case is expecting Alt+A for MacOS instead of Opt+A in keybindingIO.test.ts file

Correct me if I am wrong

@alexdima alexdima added this to the October 2021 milestone Oct 7, 2021
@alexdima alexdima added the keybindings VS Code keybinding issues label Oct 27, 2021
@alexdima alexdima modified the milestones: October 2021, On Deck Oct 27, 2021
@microsoft microsoft deleted a comment Nov 18, 2021
@alexdima
Copy link
Member

Thank you!

@alexdima alexdima merged commit c30fc3d into microsoft:main Nov 18, 2021
@alexdima alexdima modified the milestones: On Deck, November 2021 Nov 18, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jan 2, 2022
@Pranomvignesh Pranomvignesh deleted the Fix-keybindings-title branch March 23, 2022 06:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
keybindings VS Code keybinding issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants