diffEditor.renderIndicators doesn't work for peek

[svipas]

• VS Code Version: 1.56.0
• OS Version: macOS

Steps to Reproduce:

1. "diffEditor.renderIndicators": false
2. Open folder with Git repository and change something
3. Open peek git diff and you will see + and - indicators

This issue was fixed in 2018 by @joaomoreno, but seems like it still exists or maybe it's regression. Old issue: #50362

[alexdima]

@joaomoreno I could not find any hard-coding of renderIndicators: false in dirtydiffDecorator.ts as hinted in #50362 . If we would want to hard-code that to false, I think we would do that here. But hard-coding that to renderIndicators: false might mean that the embedded diff editor is no longer accessible as it would rely only on colors to convey diff information.

@svipas I've also noticed that simply configuring "diffEditor.renderIndicators": false is respected correctly in the embedded diff editor, so given we have that setting, I am not sure why we would want to hard-code them to be hidden in the embedded diff editor.

[joaomoreno]

I've went along and disabled them statically.