Allow text search providers to give messages with links that trigger researching. #123213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaomoreno
requested changes
May 10, 2021
Comment on lines
69
to
72
| setHandler(handler: (href: string) => void) { | ||
| this.handler = handler; | ||
| } | ||
|
|
There was a problem hiding this comment.
Let's just add an options? bag to the ctor of Link instead of a mutable setHandler.
There was a problem hiding this comment.
Okay, I initially didn't just because the injected openerService means everywhere this is constructed would need to explicitly pass the empty bag or undefined.
roblourens
reviewed
May 10, 2021
| @@ -579,7 +579,7 @@ export abstract class ViewPane extends Pane implements IView { | |||
| if (typeof node === 'string') { | |||
| append(p, document.createTextNode(node)); | |||
| } else { | |||
| const link = this.instantiationService.createInstance(Link, node); | |||
| const link = this.instantiationService.createInstance(Link, node, {}); | |||
There was a problem hiding this comment.
The last parameter is optional, does the instantiation service make you pass it in?
There was a problem hiding this comment.
TS doesn't allow the required service injection parameters follow an optional parameter.
roblourens
reviewed
May 10, 2021
| if (parsed.scheme === Schemas.command) { | ||
| const result = await this.commandService.executeCommand(parsed.path); | ||
| if ((result as any)?.triggerSearch) { | ||
| this.triggerQueryChange(); |
There was a problem hiding this comment.
What command are you going to use this for?
There was a problem hiding this comment.
remoteHub.enableIndexing
roblourens
reviewed
May 10, 2021
JacksonKearl
force-pushed
the
jackson/allow-messages-to-trigger-search
branch
from
b38064f
to
cb616bc
Compare
added 2 commits
May 10, 2021 21:58
roblourens
reviewed
May 11, 2021
roblourens
approved these changes
May 11, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @joaomoreno this modifies the Link class to allow setting a custom opener, to enable search to interpret the output of commands in provider messages in a way specific to the particular search UI.