[api][commands] Open new window and a file

[roblourens]

The vscode.newWindow command takes a remoteAuthority argument and opens a window on that authority. The Azure ML extension needs to open a window on a certain remote, then open a file on that remote. They do this by adding extra data to the remoteAuthority. This works but a downside is that you end up with extra entries in recently opened, since these windows have different remote authorities and are considered distinct. A better way to do this would be to allow passing in extra arguments that go to the resolver. Maybe they would be a fragment or query on the opened workspace folder URI, I don't know whether we ever do that.

[aeschli]

Maybe we should look into extra arguments to the newWindow commands? Files to open?

[roblourens]

I was just thinking of custom arguments for an extension, but yeah I guess that would work as an argument handled by vscode too. But the extension uses showNotebookDocument and might pass some other options to it too.

@SiddhanthUnnithan do you pass any extra options to showNotebookDocument or would a generic "open the file" option work for your case?

[SiddhanthUnnithan]

I was just thinking of custom arguments for an extension, but yeah I guess that would work as an argument handled by vscode too. But the extension uses showNotebookDocument and might pass some other options to it too.

@SiddhanthUnnithan do you pass any extra options to showNotebookDocument or would a generic "open the file" option work for your case?

Currently we pass "preserveFocus: False" and "preview: False" as arguments.

[aeschli]

Is this still wanted?

[shsuman]

Hi Martin,
This is a really important ask for Azure ML - Remote. Currently, we have to pass arguments in the URI itself using the following format: vscode-remote://amext+arg1={arg1}+arg2={arg2}/folderPath. This has led to multiple problems for us in the past, the most recent one being that the workspace trust prompt. Since our URI is only unique for a session (because of some telemetry tracking ids), the workspace trust prompt is shown every time we open a remote window on a Compute instance even if its the same folder.