Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Hit Condition UI for breakpoints #12373

Closed
weinand opened this issue Sep 21, 2016 · 2 comments
Closed

Implement Hit Condition UI for breakpoints #12373

weinand opened this issue Sep 21, 2016 · 2 comments
Assignees
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality
Milestone

Comments

@weinand
Copy link
Contributor

weinand commented Sep 21, 2016

SourceBreakpoints and FunctionBreakpoints support an optional hitCondition attribute which controls how many time a breakpoint has to be hit in order to 'break' execution.
Since a debug adapter is free to decide what kind of hit expressions to accept, the hitCondition is of type string.
This makes the attribute very similar to the already existing condition attribute of the breakpoint types and suggests that the UI for editing this new attribute aligns with the UI for editing breakpoint conditions.

The corresponding debug protocol addition: microsoft/vscode-debugadapter-node#37
And the implementation for node-debug: #12374

@weinand weinand added feature-request Request for new features or functionality debug Debug viewlet, configurations, breakpoints, adapter issues labels Sep 21, 2016
@weinand weinand added this to the October 2016 milestone Sep 21, 2016
@isidorn
Copy link
Contributor

isidorn commented Oct 4, 2016

Fixed via 134a1ec

breakpoint

@isidorn isidorn closed this as completed Oct 4, 2016
@isidorn
Copy link
Contributor

isidorn commented Oct 4, 2016

@weinand This is done for regular breakpoints. We have an open question on what to do for function breakpoints - since they do not have a representation in the editor. So far we have also not exposed in the ui how to add a regular condition for function breakpoints.
There are a couple of options:

  • somehow we start representing function breakpoints in the editor gutter - thus specifying the condition / hit count is the same as for regular breakpoints
  • we add context menu actions in the breakpoints pane for editing a function breakpoint, this actions could then trigger the same experience as for regular breakpoints - though where to render the widget now - since function breakpoints have no line number
  • add context menu acitons in breakpoint pane which would just open a native electron input box for specifying the condition, and another one for specifying the hit count

Let me know what you think

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

3 participants