Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use remote reconnection constants #124517

Merged
merged 4 commits into from May 24, 2021
Merged

Use remote reconnection constants #124517

merged 4 commits into from May 24, 2021

Conversation

meganrogge
Copy link
Contributor

This PR fixes #123518

@meganrogge meganrogge requested a review from Tyriar May 24, 2021 16:20
@meganrogge meganrogge self-assigned this May 24, 2021
@meganrogge meganrogge added this to the May 2021 milestone May 24, 2021
Tyriar
Tyriar approved these changes May 24, 2021
View reviewed changes
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, did you test to make sure it works with the distro changes?

src/vs/platform/terminal/common/terminal.ts Outdated Show resolved Hide resolved
src/vs/platform/terminal/node/ptyHostService.ts Outdated Show resolved Hide resolved
@meganrogge meganrogge enabled auto-merge (squash) May 24, 2021 17:31
@meganrogge meganrogge merged commit fe1af89 into main May 24, 2021
@meganrogge meganrogge deleted the merogge/ptyHost branch May 24, 2021 17:44
Ashray123 pushed a commit to Ashray123/vscode that referenced this pull request May 25, 2021
@meganrogge @Ashray123
Use remote reconnection constants (microsoft#124517)
df86f7d
@github-actions github-actions bot locked and limited conversation to collaborators Jul 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Tyriar Tyriar Tyriar approved these changes

Assignees

@meganrogge meganrogge

Labels
None yet
Projects
None yet
Milestone
May 2021
Development

Successfully merging this pull request may close these issues.

Persistent terminals only stay alive for 60 seconds after a disconnect
2 participants
@meganrogge @Tyriar