Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workspace trust - no need to call setWorkspaceTrust #124566

Merged
merged 3 commits into from May 25, 2021
Merged

Workspace trust - no need to call setWorkspaceTrust #124566

merged 3 commits into from May 25, 2021

Conversation

lszomoru
Copy link
Member

With the new resolver APIs there is no need for the extension service to call setWorkspaceTrust().

@lszomoru lszomoru added the workspace-trust Trusted workspaces label May 25, 2021
@lszomoru lszomoru added this to the May 2021 milestone May 25, 2021
@lszomoru lszomoru requested a review from alexdima May 25, 2021 09:59
@lszomoru lszomoru self-assigned this May 25, 2021
alexdima
alexdima requested changes May 25, 2021
View reviewed changes
Copy link
Member

@alexdima alexdima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 But this change effectively makes ResolvedOptions.isTrusted do nothing anymore. I'm not finding any other references to isTrusted. I would have expected to see this code replaced with some other piece of code that makes use of this flag.

@alexdima alexdima self-requested a review May 25, 2021 11:39
alexdima
alexdima approved these changes May 25, 2021
View reviewed changes
Copy link
Member

@alexdima alexdima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed offline, that there will be another piece of code doing this.

@lszomoru lszomoru merged commit b6551f8 into main May 25, 2021
@lszomoru lszomoru deleted the lszomoru/workspace-trust-extension-service branch May 25, 2021 14:06
@github-actions github-actions bot locked and limited conversation to collaborators Jul 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alexdima alexdima alexdima approved these changes

Assignees

@lszomoru lszomoru

Labels
workspace-trust Trusted workspaces
Projects
None yet
Milestone
May 2021
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lszomoru @alexdima