Add initial draft of enum array searchbox #124856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looked at this briefly and it looks fine, I will review it more later for June |
rzhao271
force-pushed
the
rzhao271/settings-list-enum
branch
2 times, most recently
from
4f4edef
to
e5294eb
Compare
roblourens
reviewed
Jun 10, 2021
src/vs/workbench/contrib/preferences/browser/settingsWidgets.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/preferences/browser/settingsWidgets.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/preferences/browser/settingsWidgets.ts
Outdated
Show resolved
Hide resolved
rzhao271
force-pushed
the
rzhao271/settings-list-enum
branch
from
418f0e7
to
2f9e6a0
Compare
roblourens
approved these changes
Jun 11, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR affects #77458.
Manual testing sample:
