Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move typescripts setLanguageConfiguration call to its JSON file. #125748

Closed
hediet opened this issue Jun 8, 2021 · 0 comments
Closed

Move typescripts setLanguageConfiguration call to its JSON file. #125748

hediet opened this issue Jun 8, 2021 · 0 comments
Assignees
@hediet @mjbvz
Labels
debt Code quality issues help wanted Issues identified as good community contribution opportunities insiders-released Patch has been released in VS Code Insiders
Milestone
Backlog

Comments

@hediet
Copy link
Member

hediet commented Jun 8, 2021 •
edited

Move typescripts setLanguageConfiguration call to its JSON file (language-configuration.json).

vscode/extensions/typescript-language-features/src/languageFeatures/languageConfiguration.ts

Line 58 in d89e2e1

const jsxTagsLanguageConfiguration: vscode.LanguageConfiguration = {

Follow up of #98621 (and its PR #124015).
@hediet hediet added bug Issue identified by VS Code Team member as probable bug debt Code quality issues labels Jun 8, 2021
@hediet hediet added this to the Backlog milestone Jun 8, 2021
@johnsoncodehk johnsoncodehk mentioned this issue Jul 30, 2021
Closed
@alexdima alexdima assigned mjbvz and unassigned alexdima Oct 12, 2021
@hediet hediet added the help wanted Issues identified as good community contribution opportunities label Oct 12, 2021
@mjbvz mjbvz removed the bug Issue identified by VS Code Team member as probable bug label Oct 21, 2021
@mjbvz mjbvz closed this as completed in 2b92835 Feb 3, 2022
@johnsoncodehk johnsoncodehk mentioned this issue Mar 7, 2022
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@hediet hediet

@mjbvz mjbvz

Labels
debt Code quality issues help wanted Issues identified as good community contribution opportunities insiders-released Patch has been released in VS Code Insiders
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
4 participants
@hediet @alexdima @mjbvz and others