Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Action terminal API #12595

Closed
2 tasks done
chrmarti opened this issue Sep 26, 2016 · 0 comments
Closed
2 tasks done

Test: Action terminal API #12595

chrmarti opened this issue Sep 26, 2016 · 0 comments

Comments

@chrmarti
Copy link
Contributor

chrmarti commented Sep 26, 2016

Test for #10917 #10925 #11275 #11384 #11919

Complexity: 5

The following changes were made to the terminal API, please test the relevant API calls to ensure they do what you think:

  • 10917: Custom terminal shells can now be launched with custom arguments (though args don't work on Windows Integrated terminal: Shell args not honored on Windows #8429):

    window.createTerminal(name?: string, shellPath?: string, shellArgs?: string[]): Terminal;
  • 10925: Expose event for when terminals are closed. Note that is it as designed that this will only fire for terminals that are created by the API:

    window.onDidCloseTerminal: Event<Terminal>
  • 11275 & Creating a terminal and sending text to it should not show it #11384: The terminal panel will only ever be showed and focused if Terminal.show(focus?) is called. In v1.5 the following called used to show the panel: window.createTerminal, Terminal.dispose, Terminal.sendText

  • 11919: Expose shell process ID. Ensure that the ID of the shell process is being exposed through the promise API:

    Terminal.processId: Thenable<number>

    The process tree is supposed to look like this:

    • VS Code renderer
      • ./terminalProcess
        • Shell process (eg. /bin/bash), the PID for this should be returned
          • Programs started from within the terminal
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants