Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Align functionality of node-debugger and chrome debugger #12600

Closed
chrmarti opened this issue Sep 26, 2016 · 1 comment
Closed

Test: Align functionality of node-debugger and chrome debugger #12600

chrmarti opened this issue Sep 26, 2016 · 1 comment
Assignees

Comments

@chrmarti
Copy link
Contributor

Test for microsoft/vscode-node-debug2#7

@roblourens
Copy link
Member

roblourens commented Sep 27, 2016

Complexity: 4

If you set "type": "node2" in a launch config, you'll be using the new debug adapter, boom.

See notes in the release notes for an overview, especially the note about Windows support.

See this bug for an overview of what's implemented.

Most existing issues are filed in vscode-chrome-debug-core, node-specific ones are in vscode-node-debug2.

There are a million scenarios we need to support, so the most valuable thing you can do is grab any random Node project that you might have debugged with VS Code in the past, change "type" to "node2", and see what happens. If anything happens that isn't the same as "node", is it obvious to figure out what's wrong?

More specific things to try, don't need to do every single one:

  • Try some things that are checked off at Node CDP Debug tasks vscode-node-debug2#7
  • Ensure it kills the process when terminating a launch config, but not an attach
  • Set breakpoints before launching, and ensure they bind
    • In the main script, and in scripts that are loaded later
  • Look in the variables pane at different types and compare it to what you'd expect
  • Test very large arrays and other stress cases
    • It might get slow but it shouldn't crash
  • Test with and without sourcemaps
  • Attach config with a running process (start with --inspect=9229)

@jrieken jrieken removed their assignment Sep 27, 2016
This was referenced Sep 27, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants