Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test VS Live Server/Preview - External Browser Preview #127165

Closed
3 tasks done
andreamah opened this issue Jun 25, 2021 · 1 comment
Closed
3 tasks done

Test VS Live Server/Preview - External Browser Preview #127165

andreamah opened this issue Jun 25, 2021 · 1 comment

Comments

@andreamah
Copy link
Contributor

andreamah commented Jun 25, 2021

Refs #124608

Complexity: 3

Create Issue


Prep

Please download the extension from the marketplace. The features should be explained in the Features section of the README.

Switch to use the external preview by selecting it in the Live Preview settings
image

Test

Please play around with the extension and file issues for UX suggestions and/or bugs!

!!! Please test primarily with the external browser preview, as there is a separate testplan item testing the embedded preview #127164 !!!

Focus on Testing

Features Exclusive to External Browser Preview'

  • Testing that opening the external preview will run the Live Server task if one is not already running (to run a persistent server for the external browsing).
  • Ability to link SVG files, ie: <object type="image/svg+xml" data=SVG_FILE_NAME></object> in your HTML.

Generic Live Server Features

  • Running the Live Preview task (using --verbose and without it).
    • Using the links in the task's pseudo-terminal (clicking on the blue server URLs to open/reveal files) and the http://127.0.0.1/<PORTNUM> to open the index in preview. Note: clicking on directory links should reveal the folder in the file explorer if possible and file links should open the file.
      image
  • Using the different preview-refreshing settings to see if the preview refreshes when expected.
    image
  • Rendering special characters (ie: emojis) in the HTML.
  • Using links to navigate between pages.
  • Navigating the file system hosted by the server using the default index page (should show up when showing index if no index.html is available).
  • Previewing files that are not a part of the current workspace OR previewing any files with no workspace open.
    • Using the custom task when previewing files that are not a part of the current workspace.
  • Testing the multi-workspace scenario (allows user to choose workspace for server, defaults to first workspace)

Known limitations

Most of the known limitations have to do with the out-of-workspace previewing.

  • If you have a preview of a non-workspace file and reload the window, the webview will either revive at the index of the current workspace (if one was open) or it will dispose of itself (if no workspace was opened). This is because the encoded endpoint names (and what they map to) do not persist between sessions.
  • If you choose to preview a non-workspace file, links that are not a descendant of the file's parent (ie: ../../file.html) will not link correctly. This is because the custom endpoint created for the non-workspace file only hosts from the parent of the current file.
@aeschli
Copy link
Contributor

aeschli commented Jun 30, 2021

Works well!

@github-actions github-actions bot locked and limited conversation to collaborators Aug 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants