Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No bracket matching and auto indent in CSS (HTML, Handlebars) #12757

Closed
bpasero opened this issue Sep 27, 2016 · 3 comments
Closed

No bracket matching and auto indent in CSS (HTML, Handlebars) #12757

bpasero opened this issue Sep 27, 2016 · 3 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority verified Verification succeeded

Comments

@bpasero
Copy link
Member

bpasero commented Sep 27, 2016

Testing #12100

Have a style block with some CSS in either a HTML or Handlebars file. Notice that:

  • bracket matching does not work
  • auto indent does not work

Since this works in CSHTML, I wonder if this is something easy to configure?

Marking important because I think this is a very common thing to do for our users.

@alexandrudima fyi since @aeschli is out

@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority labels Sep 27, 2016
@alexdima
Copy link
Member

@bpasero I suggest tweaking the language configuration of HTML. Due to the migration to TextMate, the editor core is no longer aware that there is a mode switch occuring in HTML and will therefore consider everything as HTML, and will use the brackets defined in HTML:

image

@alexdima alexdima added this to the September 2016 milestone Sep 27, 2016
@alexdima
Copy link
Member

@jrieken I'm also gonna be out :)

@bpasero bpasero self-assigned this Sep 28, 2016
@bpasero
Copy link
Member Author

bpasero commented Sep 28, 2016

@alexandrudima thanks!

@aeschli I did was Alex suggest and add more brackets to the HTML and Handlebars config (f6d0cc1)

I noticed another difference: Handlebars and Razor define surroundingPairs with { "open": "<", "close": ">" } while HTML does not. Not sure what the impact is of that.

@Tyriar Tyriar added the verified Verification succeeded label Sep 29, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants