[FR] editor.emmet.action.updateTag fragment support

[wenfangdu]

Currently, when using editor.emmet.action.updateTag to rename tags, there's no way to rename the tag to be a fragment (<></>).

Also, when the editor.emmet.action.updateTag prompt shows up, hitting enter does the same thing as escape - nothing happens.

Therefore, I propose a heuristic here - if the renamed tag name is empty (hit enter), rename the tag to a fragment.

[rzhao271]

Changing the code to support this is easy enough, but the fragment renders as follows:

I'm not sure if that's the behaviour you expect?

CC @aeschli

[wenfangdu]

@rzhao271 That looks strange, if <></> is typed by hand, it will be rendered in the same color:

[rzhao271]

I wonder if it depends on your theme and settings?
I changed around the theme and noticed the <></> rendered in a single colour for Quiet Light and Red.

[wenfangdu]

@rzhao271 I'm using the default dark theme with no settings and no extensions enabled.

In all the themes listed below, none could cause multiple colors for me:

Can you retry with no settings and no extensions enabled?

[rzhao271]

Even with no settings and no extensions (and setting sync off), I get a different colour for the invalid token:

[wenfangdu]

@rzhao271 I see, you're using <></> in the html, that's why it has different colors, I was using them in jsx and tsx files without problems. It seems like a syntax parsing and highlighting issue given <></> isn't valid html.

[rzhao271]

I took a look into this issue today. Fragment support is lacking in general. For example, even after I allow updating the tag to '' in JSX, I see the following two issues:

1. If there's attributes in the original tag, the attributes aren't erased.
2. I'm unable to update a fragment tag.