Terminal background color dimmed after update.

[RayPS]

Does this issue occur when all extensions are disabled?: Yes

• VS Code Version: 1.58.0
• OS Version: macOS Big Sur 11.4 Apple Silicon

Steps to Reproduce:

1. Open Terminal in VS Code.

Just updated VS Code, the Terminal background suddenly appeared to be dimmed/grayed out. I haven't updated VS Code for at least a month, so not sure which version causes this issue.

• I've tried disabling themes/extensions, switching shell to bash, issue still remain.
• Running with code --disable-gpu can be temporary solve the issue.
• This issue does not exist in Insider version at all.
  --- edit ---
• Setting "terminal.integrated.gpuAcceleration" to "auto" can be temporary fix the issue for me, some users are different by setting this to on / off.
• This issue also exist in Insider version when "terminal.integrated.gpuAcceleration" set to "canvas".

Related to #69309 & #71568 but those were locked without a solution. Sorry if this are duplicated.

[kirill-martynov]

Same thing.
Using same color #2e3440 for editor.background and terminal.background, but for terminal it looks like darker/dimmed.

checked with color picker and saw that terminal.background color have rgb 34 39 49 and editor.background have rgb 40 45 57

but both set to #2e3440

[kirill-martynov]

as @RayPS said this really fix the issue:

[dlschmidt]

Turning off GPU acceleration also fixes this issue for editor-like terminals, i.e. using

"terminal.integrated.defaultLocation": "editor"

... but the integrated terminal is brighter afterwards.

[RomnKo]

For me GPU Acceleration was set to Auto, so I changed it to On and that fixed it for me. Looks like any setting but Canvas look good. Canvas is the one that changes the terminal color.

[memeplex]

I'm seeing this too in macOS. Both gpu accel on and off seem to work around the issue, but canvas looks bad.

[Tyriar]

Thanks for the info all, action items:

• Why are users seeing differences between "auto" and "on"
• Investigate why the background color isn't set right when set to "canvas"

[wavebeem]

Seeing this too when the terminal is set to canvas rendering. My setting was originally "auto", but now after messing with it, only "canvas" reproduces the issue. Perhaps "auto" was picking canvas behind the scenes previously for some reason.

Version: 1.58.2 (Universal)
Commit: c3f1263
Date: 2021-07-14T22:09:06.581Z
Electron: 12.0.13
Chrome: 89.0.4389.128
Node.js: 14.16.0
V8: 8.9.255.25-electron.0
OS: Darwin x64 20.5.0

[Tyriar]

I can't reproduce this on Catalina. While thinking about it, it reminds me of an old issue where the terminal was actually rendering "correctly" according to the theme color and it was everything else that was wrong.

@deepak1556 do you know how the color profile stuff works and are you familiar with this issue on Big Sur(+?) where color codes in the theme are changed when rendered? The screenshot above shows the terminal is #1e1e1e which is the default for Dark+ but the editor is #181818.

Related: #111645

[Tyriar]

Not sure why this seems to happen on canvas only but not the webgl renderer. FWIW gpuAcceleration: auto is improved in Insiders so hopefully people will stop wrongly getting the canvas renderer and use the better webgl one which doesn't show this issue.

[wavebeem]

@Tyriar I just checked my color codes, it's definitely the wrong color in the canvas terminal, not the other way around, fyi 😄

[Tyriar]

So confused lol

[wavebeem]

In case it helps, I didn't noticed this until I used a dark theme. In my regular light theme, the terminal is #f3f3f3 instead of #f5f5f5

So the gray value goes from 245/255 (0.961) to 243/255 (0.953), or minus 2.

[Tyriar]

Cannot reproduce by explicitly setting terminal.background with any value of terminal.gpuAcceleration.

[memeplex]

Neither do I.

[sagebind]

I can consistently reproduce this today specifically with terminals in the editor area (similar to #127156) as I experience it every day for the past few months. Here's full reproduction steps:

• Install a fresh copy of VS Code Insiders (no extensions or customizations). At time of writing I reproduced this with commit dc1a6699060423b8c4d2ced736ad70195378fddf.
• Install a theme with a different background color for panel terminal and editor. In this case, https://marketplace.visualstudio.com/items?itemName=swashata.beautiful-ui. Note that this is a theme pack, but can be reproduced with most themes in this pack. The theme shown below is βui - One Dark.
• Create a new terminal in the editor area.
• Ensure that GPU acceleration is on (terminal.integrated.gpuAcceleration).
• Observe the background color discrepancy:

Using the developer tools, you can see that while .editor-container has an inline style of background-color: rgb(38, 42, 49);, the inner element .xterm-viewport has the inline style of background-color: rgb(24, 26, 30);, which does not match the editor area.

Somehow the setting terminal.integrated.gpuAcceleration is actually involved here, because when changed to off, suddenly everything looks correct:

Though the background color of the inner element .xterm-viewport is still the wrong value, it seems to no longer have an impact. I am presuming this is still a VS Code bug, but I suppose that somehow this could be an issue with the theme itself though I'm not sure how.

This test was done on macOS 11.6.

[Tyriar]

@sagebind that looks like a different problem which isn't handled right now, tracking in #135968

[sagebind]

Thanks! I wasn't entirely sure if it was the same issue or not. I'll watch the new case for updates.