Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add isDefault to TaskGroup API #128596

Merged
merged 7 commits into from Jul 15, 2021

Conversation

headerjson
Copy link
Contributor

@headerjson headerjson commented Jul 14, 2021

This PR fixes #79188

Description

This PR adds the isDefault property to the TaskGroup interface by first adding it to the TaskGroup2 proposed API and adding the property to all the DTOs.

Tested By

Added new API task to workspace.tasks.test.ts which first sets the default in directly in the tasks.json file, then ensures that the "group" property is set when the task is retrieved.
Ran tests using .\scripts\test-integration.bat

@headerjson headerjson marked this pull request as ready for review July 14, 2021 01:09
Copy link
Member

@alexr00 alexr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@alexr00 alexr00 merged commit 48975dc into microsoft:main Jul 15, 2021
@alexr00 alexr00 added this to the July 2021 milestone Jul 15, 2021
alexr00 added a commit that referenced this pull request Jul 16, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Aug 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider adding isDefault to TaskGroup
2 participants