Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot set breakpoint in latest version of VSCode with my debug adapter - used to work fine before #129361

Closed
dibyendumajumdar opened this issue Jul 25, 2021 · 7 comments
Assignees
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues

Comments

@dibyendumajumdar
Copy link

Does this issue occur when all extensions are disabled?: Yes/No

  • VS Code Version: 1.58.2
  • OS Version: Windows 10

Steps to Reproduce:

  1. Install 'Lua and Ravi 5.3 Debugger'
  2. Open a Lua script to debug
  3. Try setting a breakpoint.

In recent versions it is not possible to set break points - this seems to have broken since some release of VSCode but I am not sure since when.

Nothing happens when I click on the area where I would normally click to set breakpoint.

I am attaching a sample interaction log - I don't see any setBreakpoints request going to the debug adapter.

out1.txt

@dibyendumajumdar
Copy link
Author

Hi @weinand I am not sure what has changed as when I last updated my adapter in 2020 it used to work fine.

@gjsjohnmurray
Copy link
Contributor

@dibyendumajumdar I suggest you perform a bisect procedure, installing earlier versions of VS Code until you discover exactly which version your extension stopped working with. Then review that version's release notes.

Release notes for all previous versions are available from the index pane on the left of the page at https://code.visualstudio.com/updates and at the top of each set of release notes there are links for downloading the installers for that version.

@dibyendumajumdar
Copy link
Author

dibyendumajumdar commented Jul 25, 2021

vscode-bug.mp4

Hi - I checked earlier versions - its broken since 1.53.

Recording showing it worked fine in 1.52

@weinand weinand added the debug Debug viewlet, configurations, breakpoints, adapter issues label Jul 26, 2021
@weinand weinand removed their assignment Jul 26, 2021
@weinand
Copy link
Contributor

weinand commented Jul 26, 2021

@isidorn IIRC we've removed the deprecated "Debuggers" contributions point for breakpoints, right?

@dibyendumajumdar
Copy link
Author

It seems that I need to add following in the package.json:

	"contributes": {
		"breakpoints": [{ "language": "lua" }],

I manually amended the package.json in the deployed extension and saw the breakpoints showed up in 1.58.

So the way this works was changed in 1.53? I didn't see any instructions related to this in the release notes.

@dibyendumajumdar
Copy link
Author

Okay I see instruction in 1.42 release notes.

I will close this issue - but one question: was it necessary to make a breaking change?

@isidorn
Copy link
Contributor

isidorn commented Jul 26, 2021

Sorry about the breaking change. And I am glad you found the instructions on how to mitigate.
It was necessary.

@isidorn isidorn closed this as completed Jul 26, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Sep 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues
Projects
None yet
Development

No branches or pull requests

4 participants