Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instruction breakpoints should maybe use a different breakpoint icon #129543

Open
isidorn opened this issue Jul 27, 2021 · 5 comments
Open

Instruction breakpoints should maybe use a different breakpoint icon #129543

isidorn opened this issue Jul 27, 2021 · 5 comments
Assignees
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues debug-disassembly under-discussion Issue is under discussion for relevance, priority, approach
Milestone

Comments

@isidorn
Copy link
Contributor

isidorn commented Jul 27, 2021

#129161

@yuehuang010, @xisui-MSFT

Instructions breakpoints currently use the same icon as regular breakpoints.
We could introduce a new icon to make them more distinguishable?

Maybe a red square? We already have a diamond and triangle. @misolori what do you think? (instruction breakpoint can be added from the disassembly view which we just introduced this milestone).
@yuehuang010 @xisui-MSFT what does Visual Studio use, regular red circle?

Screenshot 2021-07-27 at 15 41 53

@isidorn isidorn added debug Debug viewlet, configurations, breakpoints, adapter issues under-discussion Issue is under discussion for relevance, priority, approach labels Jul 27, 2021
@xisui-MSFT
Copy link
Contributor

VS doesn't have a different icon. But we would like to use a different icon for this as this seems to be a convention in VS Code.

@yuehuang010 will work on this.

@yuehuang010
Copy link
Contributor

@isidorn, Thoughts on this icons? ⯍/⯏

@isidorn
Copy link
Contributor Author

isidorn commented Jul 28, 2021

@isidorn make sure it is red so it is aligned with other breakpoints.
I would just go with the red square 🟥

For reference checkout function breakpoint icons in vscode 🔺

I suggest that we only do this next milestone, so assigning to August.

@isidorn isidorn added this to the August 2021 milestone Jul 28, 2021
@miguelsolorio
Copy link
Contributor

So a red square would look something like:

image

@weinand weinand removed their assignment Aug 18, 2021
@isidorn isidorn modified the milestones: August 2021, Backlog Aug 26, 2021
@isidorn isidorn assigned roblourens and unassigned isidorn Aug 26, 2021
@daviddossett daviddossett removed their assignment Dec 6, 2022
@gjsjohnmurray
Copy link
Contributor

See also #177221 for other discussions about breakpoint shapes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues debug-disassembly under-discussion Issue is under discussion for relevance, priority, approach
Projects
None yet
Development

No branches or pull requests

8 participants