Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format html/handlebars messes up on meta tags #12964

Closed
bgashler1 opened this issue Sep 29, 2016 · 3 comments
Closed

Format html/handlebars messes up on meta tags #12964

bgashler1 opened this issue Sep 29, 2016 · 3 comments
Assignees
Labels
*as-designed Described behavior is as designed formatting Source formatter issues

Comments

@bgashler1
Copy link
Contributor

  • VSCode Version: Insiders
  • OS Version: Windows 10

Regarding test plan item #12100

Steps to Reproduce:

  1. Have a block of handlebars code with metadata (this should also apply to html; it seems to already be a bug in the existing stable build for html)
  2. Format this block of code.
  3. Note that sometimes metadata tags are orphaned onto their own lines of code.

Before formatting
screen shot 2016-09-28 at 6 04 02 pm

After formatting
screen shot 2016-09-28 at 6 05 03 pm

Does not match the output of http://jsbeautifier.org/
screen shot 2016-09-28 at 6 07 34 pm

@bgashler1 bgashler1 added bug Issue identified by VS Code Team member as probable bug formatting Source formatter issues labels Sep 29, 2016
@bgashler1 bgashler1 added this to the September 2016 milestone Sep 29, 2016
@dbaeumer dbaeumer modified the milestones: October 2016, September 2016 Sep 29, 2016
@dbaeumer
Copy link
Member

According to @bgashler1 no regression. Moving to October.

@aeschli
Copy link
Contributor

aeschli commented Oct 11, 2016

@bgashler1 Can you still have the example code. Can you paste it here?

@aeschli
Copy link
Contributor

aeschli commented Oct 11, 2016

I reproduced with

{{#section 'metatags'}}
<meta name="test" content="vas adbasdv adv hasdsad jaasd  asds asdsd asd asd as ad sdasd  jadasdd asdasdas dasdasd asdas das dsdasd jasdasd " />
<meta name="test2" content="test" />
{{/section}}

The line break is added as our default settings specify:
html.format.wrapLineLength": 120,

Closing as not a bug.

@aeschli aeschli closed this as completed Oct 11, 2016
@aeschli aeschli removed the bug Issue identified by VS Code Team member as probable bug label Oct 11, 2016
@aeschli aeschli removed this from the October 2016 milestone Oct 27, 2016
@aeschli aeschli added the *as-designed Described behavior is as designed label Oct 27, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*as-designed Described behavior is as designed formatting Source formatter issues
Projects
None yet
Development

No branches or pull requests

3 participants