Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[html] format inside the script tag #12972

Closed
bgashler1 opened this issue Sep 29, 2016 · 4 comments
Closed

[html] format inside the script tag #12972

bgashler1 opened this issue Sep 29, 2016 · 4 comments
Assignees
@aeschli
Labels
feature-request Request for new features or functionality html HTML support issues
Milestone
Backlog

Comments

@bgashler1
Copy link
Contributor

  • VSCode Version: Insiders
  • OS Version: Windows 10

Regarding test plan item #12100

Steps to Reproduce:

  1. Select all the contents of an html file that has a script tag block somewhere in it (mine was at the bottom)
  2. Run "Format Code"
  3. Note that nothing inside the <script> tag was formatted.

This also is a problem in Stable, and Stable also has another problem where the selection no longer includes everything.
@bgashler1 bgashler1 added this to the September 2016 milestone Sep 29, 2016
@dbaeumer dbaeumer modified the milestones: October 2016, September 2016 Sep 29, 2016
@dbaeumer dbaeumer added the feature-request Request for new features or functionality label Sep 29, 2016
@dbaeumer
Copy link
Member

This never worked IMO.

@aeschli
Copy link
Contributor

aeschli commented Oct 11, 2016

Not a regression, the HTML formatter never touched the JavaScript.

@aeschli aeschli modified the milestones: Backlog, October 2016 Oct 11, 2016
@aeschli aeschli added the html HTML support issues label Oct 11, 2016
@aeschli aeschli changed the title Formating HTML does not format anything inside the script tag [html] format inside the script tag Oct 11, 2016
@aeschli aeschli mentioned this issue Oct 14, 2016
Closed
@cliffkoh
Copy link

This is a dupe of #5076.

@aeschli aeschli mentioned this issue Nov 9, 2016
Closed
@aeschli
Copy link
Contributor

aeschli commented Feb 7, 2017

Duplicate of #5076, implemented in the December build.

@aeschli aeschli closed this as completed Feb 7, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@aeschli aeschli

Labels
feature-request Request for new features or functionality html HTML support issues
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
4 participants
@cliffkoh @dbaeumer @aeschli @bgashler1