Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding a div causes an extra stray bracket in Razor #12975

Closed
bgashler1 opened this issue Sep 29, 2016 · 4 comments
Closed

Adding a div causes an extra stray bracket in Razor #12975

bgashler1 opened this issue Sep 29, 2016 · 4 comments
Assignees
@egamma @aeschli
Labels
bug Issue identified by VS Code Team member as probable bug verification-needed Verification of issue is requested verified Verification succeeded
Milestone
September 2016

Comments

@bgashler1
Copy link
Contributor

  • VSCode Version: Insiders
  • OS Version: Windows 10

Regarding test item #12100

Steps to Reproduce:

  1. Type <div and press Tab repeatedly until it completes to <div></div>>
  2. Note the extra > at the end that was not there before

Insiders pictured below
![insiders - extra closing bracket](https://cloud.githubusercontent.com/assets/11839736/18942587/eb4dea9a-85ce-11e6-9639-95b35e2e7f47.g

In Stable today, there is no extra bracket.
@bgashler1 bgashler1 added the bug Issue identified by VS Code Team member as probable bug label Sep 29, 2016
@bgashler1 bgashler1 added this to the September 2016 milestone Sep 29, 2016
@dbaeumer dbaeumer assigned sandy081 and egamma and unassigned sandy081 Sep 29, 2016
@dbaeumer
Copy link
Member

This is emmet related.

@egamma
Copy link
Member

egamma commented Sep 29, 2016

This isn't a regression. What has changed in September is that < is now auto closed with '>'. This uncovers the emmet behaviour.

As an initial fix I've removed the auto closing of '<', this makes the behaviour consistent with August.

@egamma
Copy link
Member

egamma commented Sep 29, 2016

Also change the emmet editor access to consume a trailing '>'

@egamma egamma added the verification-needed Verification of issue is requested label Sep 29, 2016
@egamma egamma mentioned this issue Sep 29, 2016
Closed
@egamma egamma closed this as completed Sep 29, 2016
@egamma
Copy link
Member

egamma commented Sep 29, 2016

@dbaeumer pls verify

@octref octref added the verified Verification succeeded label Sep 29, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@egamma egamma

@aeschli aeschli

Labels
bug Issue identified by VS Code Team member as probable bug verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
September 2016
Development

No branches or pull requests
6 participants
@egamma @dbaeumer @octref @aeschli @sandy081 @bgashler1