Default terminal profile setting is ignored

[vaindil]

Issue Type: Bug

I have a custom terminal profile in my settings.json file like I always have. This terminal always opened by default prior to today's update. Today, however, the PowerShell terminal is always opening by default (either when opening VS Code fresh or clicking the + icon in the terminal area to create a new one). I found the setting terminal.integrated.defaultProfile.windows and set that to my profile, but it has no effect. I do not have either terminal.integrated.shell.windows or terminal.integrated.shellArgs.windows specified, so the default profile should be honored, but it's not. Setting the default profile to one of the built-in options, like Command Prompt, also has no effect. Opening my custom profile manually using the dropdown to explicitly choose it works just fine, it just refuses to open by default.

These are the only lines in settings.json that contain the text terminal (other than a bunch of lines that are just hex color codes):

"terminal.integrated.profiles.windows": {
  "cmder": {
    "path": "C:\\WINDOWS\\System32\\cmd.exe",
    "args": [
      "/K",
      "C:\\path\\Cmder\\vendor\\bin\\vscode_init.cmd"
    ]
  }
},
"terminal.integrated.defaultProfile.windows": "cmder",

VS Code version: Code - Insiders 1.60.0-insider (49af1cb, 2021-08-06T06:41:50.275Z)
OS version: Windows_NT x64 10.0.19043
Restricted Mode: No

System Info

Item	Value
CPUs	Intel(R) Core(TM) i7-9850H CPU @ 2.60GHz (12 x 2592)
GPU Status	2d_canvas: enabled gpu_compositing: enabled multiple_raster_threads: enabled_on oop_rasterization: enabled opengl: enabled_on rasterization: enabled skia_renderer: enabled_on video_decode: enabled vulkan: disabled_off webgl: enabled webgl2: enabled
Load (avg)	undefined
Memory (System)	31.79GB (16.61GB free)
Process Argv	--disable-extensions --crash-reporter-id a705106d-83f5-430f-bc96-f3ab88b46638
Screen Reader	no
VM	0%

Extensions disabled

A/B Experiments

vsliv695:30137379
vsins829:30139715
vsliv368cf:30146710
vsreu685:30147344
python383:30185418
pythonvspyt602:30291494
vspor879:30202332
vspor708:30202333
vspor363:30204092
vswsl492:30256197
pythonvspyt639:30291487
pythontb:30258533
pythonvspyt551cf:30291413
pythonptprofiler:30281269
vsdfh931:30280409
vshan820:30294714
pythondataviewer:30285072
pythonvsuse255:30319630
vscod805:30301674
pythonvspyt200:30323110
vsccppwt:30312692
pythonvssor306:30340298
bridge0708:30335490
pygetstartedt:30346833
dockerwalkthrucf:30346919

[vscodebot]

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

• Terminal profiles do not appear in the menu, "Select Default Profile" does nothing (#121722)
• Startup Terminal profile is always powershell (#126732)
• Terminal dropdown doesn't show extension contributed profile as default (#129611)
• Add profile for cmder (#125387)

[vaindil]

I see #126732, which is my issue, but it's closed without much info. This is a new issue that started only in today's build for me.

I also see #121722, but it doesn't seem to be quite the same. I don't have the other issues mentioned there, just that the default profile setting doesn't work.

[cdxn]

as @vaindil stated: this started today. Not only are profile settings ignored (User, Remote, Workspace), the prior terminal.integrated.shell.linux is also ignored. Windows 10 + WSL2 Ubuntu 20.04 + VSCode insiders.

Always launches integrated using $SHELL, and launches in home, not path from which VSCode was provided.

Version: 1.60.0-insider (user setup)
Commit: 49af1cb
Date: 2021-08-06T06:41:50.275Z
Electron: 13.1.7
Chrome: 91.0.4472.124
Node.js: 14.16.0
V8: 9.1.269.36-electron.0
OS: Windows_NT x64 10.0.19043

[meganrogge]

Thanks for catching this. will be fixed in tomorrow's insider's.

[vaindil]

@meganrogge This only appears to be partially fixed in the latest insiders build. Clicking the + icon works to open the default terminal, but PowerShell is still opened when I initially open a VS Code window (either the first instance or a new window). Looks like #128763 is being used for this, so I'll comment over there too.

[cdxn]

@vaindil @meganrogge - observed same behavior on Windows + WSL2. Initial integrated terminal falls back to $SHELL. +, or Ctrl + ` launches using profile.

[dippas]

This is still not fixed, when restarting/open @meganrogge

[meganrogge]

/duplicate of #128763 - this issue tracks the issue with setting a default profile and creating with the + button not working (not including on launch), which has been fixed.

[KathRains]

I noticed this problem today after the recent update of VS Code. My default profile is Command Prompt and I do have the default settings for it but PowerShell is loaded ignoring them

    "terminal.integrated.profiles.windows": {
        "PowerShell": null,
        "Command Prompt": {
            "path": [
              "${env:windir}\\System32\\cmd.exe"
            ]
        }
    },
    "terminal.integrated.defaultProfile.windows": "Command Prompt"