Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to configure environment variables for extension host #130493

Open
bl-ue opened this issue Aug 10, 2021 · 6 comments
Open

Allow to configure environment variables for extension host #130493

bl-ue opened this issue Aug 10, 2021 · 6 comments
Labels
extension-host Extension host issues feature-request Request for new features or functionality
Milestone

Comments

@bl-ue
Copy link

bl-ue commented Aug 10, 2021

I've got a really simple problem: often I open VS Code from a terminal, because I need to run export PATH=... in order to be able to use some extension inside of VS Code that uses a binary to work, e.g., this Lilypond extension, which works really well (thank you @lhl2617!), uses the lilypond external binary.

Perhaps a workspace could have environment variables in addition to project folders? 🤔

@bl-ue bl-ue changed the title Environments or environment variables in workspaces? Environment variables in workspaces Aug 11, 2021
@lhl2617
Copy link

lhl2617 commented Aug 12, 2021

FYI: you don't need to shove the PATH there :) you can specify the path in the settings.

https://github.com/lhl2617/VSLilyPond/blob/HEAD/docs/INSTALL.md#lilypond-setup-guide

@bl-ue
Copy link
Author

bl-ue commented Aug 12, 2021

Aha! Very nice trick. Dumb of me not to read such a simple guide 😆

Still, the theme of my idea remains the same.

@wickerwaka
Copy link

Yes, I agree that the idea is useful even if you specific example can be solved in another way. There are plenty of other cases where being able to set specific environment variables for a workspace would be useful.

@sandy081 sandy081 assigned bpasero and unassigned sandy081 Aug 20, 2021
@bpasero bpasero added feature-request Request for new features or functionality workbench-os-integration Native OS integration issues and removed workspace-edit labels Aug 20, 2021
@bpasero bpasero removed their assignment Aug 20, 2021
@bpasero bpasero added extension-host Extension host issues and removed workbench-os-integration Native OS integration issues labels Aug 20, 2021
@bpasero bpasero changed the title Environment variables in workspaces Allow to configure environment variables for extension host Aug 20, 2021
@sanmai-NL
Copy link

This is important to set universally relevant configurations in a DRY way, such as JAVA_HOME, which is depended on by multiple popular VS Code extensions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extension-host Extension host issues feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

8 participants
@bpasero @sanmai-NL @wickerwaka @rzhao271 @sandy081 @lhl2617 @bl-ue and others