Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run search in extension host as an experiment #130532

Closed
roblourens opened this issue Aug 11, 2021 · 5 comments
Closed

Run search in extension host as an experiment #130532

roblourens opened this issue Aug 11, 2021 · 5 comments
Assignees
Labels
feature-request Request for new features or functionality sandbox Running VSCode in a node-free environment search Search widget and operation issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@roblourens
Copy link
Member

A sandboxed renderer process can't spawn the search process. We already run search in the EH in remote windows. We also still have a plan to enable extensions to contribute search providers which would run in the EH. We can add a setting to opt-in to running search in the EH all the time, and also enable it as an experiment to see if it causes any issues.

@roblourens roblourens added feature-request Request for new features or functionality search Search widget and operation issues labels Aug 11, 2021
@roblourens roblourens added this to the August 2021 milestone Aug 11, 2021
@roblourens roblourens self-assigned this Aug 11, 2021
@bpasero bpasero added the sandbox Running VSCode in a node-free environment label Aug 11, 2021
@roblourens roblourens added verification-needed Verification of issue is requested verified Verification succeeded labels Aug 24, 2021
@roblourens
Copy link
Member Author

(No verification needed, it's running this way in Insiders and won't in stable)

@bpasero
Copy link
Member

bpasero commented Aug 24, 2021

@roblourens should this get a test plan item though?

@roblourens roblourens removed the verified Verification succeeded label Aug 24, 2021
@roblourens
Copy link
Member Author

I guess verification-needed would be good.

  • Check that text/file search features work
  • Open the process explorer, there should be no "searchProcess"

@bpasero
Copy link
Member

bpasero commented Aug 24, 2021

@roblourens is it expected that more than one rg process run though? On the vscode workspace with any exclusions disabled I searched and tried to monitor the running rg processes with htop:

image

@bpasero bpasero added the verified Verification succeeded label Aug 24, 2021
@roblourens
Copy link
Member Author

htop shows individual threads by default (even though they have different "PIDs") it may be one process. But there is one proc per workspace folder and per search instance.

@github-actions github-actions bot locked and limited conversation to collaborators Oct 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality sandbox Running VSCode in a node-free environment search Search widget and operation issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

2 participants