Emoji keyboard opens in the wrong place

[roblourens]

Ctrl+cmd+space to open this on OSX. Sometimes it's on the wrong monitor, sometimes it's fairly close like in the gif. Everywhere else in the system, it opens pointing at the cursor or focused input box, so I'm guessing it's something we actually have control over somehow. If the cursor is in a basic input box like the find widget, marketplace search box, etc, then it shows up in the right place.

[alexdima]

It shows at the top of the editor, where we keep the textarea

[Tyriar]

@alexandrudima do you move the text area under the cursor when doing an IME composition? I was expecting an emoji IME to act the same as a language IME.

[roblourens]

In the gif that appears to be the case but I see it in different places depending on where the cursor is.

[alexdima]

I move the textarea to the cursor location when I get a compositionstart event. Chromium/Electron doesn't give a compositionstart event when popping up the emoji picker

[mushanshitiancai]

I meet similar problem with Chinese IME.

[cesarvarela]

Not just chinese

[alexdima]

After ad023e4 and 689a607 (done for #356) here is the status:

@mushanshitiancai Chinese IME is tracked in #356 . The first time, the suggestions pop up at the correct location. On a second usage, the suggestions pop up at the top left window position. This appears now to be an upstream bug which I've filed against Electron.

@cesarvarela This now works correctly:

[alexdima]

After my latest change, the emoji picker shows "really close" to the primary cursor. I can only guess that the emoji picker is positioned in a way that does not account for the overflow: hidden of the textarea and tries really hard (but fails) to position itself next to the native cursor inside the textarea:

[roblourens]

What I see now is that it's always right on the cursor but maybe a little too close for comfort. Huge improvement though! Opening a new issue.