Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VS Code 1.60.0-insider no long respect tokenColorCustomizations for brackets #131228

Closed
pingshunhuangalex opened this issue Aug 20, 2021 · 5 comments

Comments

@pingshunhuangalex
Copy link

pingshunhuangalex commented Aug 20, 2021

Does this issue occur when all extensions are disabled?: Yes/No

  • VS Code Version: 1.60.0-insider
  • OS Version: MacOS Catalina

Just restart VS Code Insider to get the update, and it comes back with a bunch of colourful brackets with a weird choice of colours... (I config my bracket to only use specific color based on its type)
Screen Shot 2021-08-20 at 11 43 22 am

Another thing I noticed that's been on for a while is in the setting page (side by side json), we no longer have the edit button in the left panel for each item. This also takes the scroll sync with it which makes checking configs a huge pain...

@pingshunhuangalex
Copy link
Author

Actually lots of the syntax highlighting are different after the update. It tries to apply my tokenColorCustomizations override but fails here and there all over the place... Hopefully, it's not an intended change. Every time something happens to theme and syntax highlighting, it just completely destroyed my day and workflow

@gjsjohnmurray
Copy link
Contributor

See #129231 for incoming feature. Looks like it is enabled by default.

@pingshunhuangalex
Copy link
Author

Thanks so much @gjsjohnmurray "editor.bracketPairColorization.enabled": false, saved the day.

By any chance you also know the answer to my second question? (sorry for being lazy here instead of opening a separate ticket)

Another thing I noticed that's been on for a while is in the setting page (side by side json), we no longer have the edit button in the left panel for each item. This also takes the scroll sync with it which makes checking configs a huge pain...

@gjsjohnmurray
Copy link
Contributor

See #130262

@pingshunhuangalex
Copy link
Author

Oh no, not sure why the team decides to do this. Well, thanks @gjsjohnmurray again for the link.

@github-actions github-actions bot locked and limited conversation to collaborators Oct 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants