Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax-Highlighting differs since Insider 1.60 #131246

Closed
Raydir opened this issue Aug 20, 2021 · 8 comments
Closed

Syntax-Highlighting differs since Insider 1.60 #131246

Raydir opened this issue Aug 20, 2021 · 8 comments
Assignees

Comments

@Raydir
Copy link

Raydir commented Aug 20, 2021

Hey there

I just mentionend that the latest Insider build did mess with the colorization of my syntax-highlithing

Stable 1.59.1
grafik

Insider 1.60
grafik

Extension for reproduction:
https://marketplace.visualstudio.com/items?itemName=OpaccSoftwareAG.f-script

Any advice / idea on what did change the color of the "guillets"? (« / »)

Regards
Roman

@Raydir
Copy link
Author

Raydir commented Aug 20, 2021

Also differs on Monokai:
grafik

@IllusionMH
Copy link
Contributor

IllusionMH commented Aug 20, 2021

This is built-in brackets pairs colorization #129231
"editor.bracketPairColorization.enabled": false will disable it.

Also see #131176

@jaymegordo
Copy link

The bracket colorization could be helpful, but pretty ugly without the ability to customize the colors for each level. Is this available? Currently I just see a setting to turn it off or on.

@IllusionMH
Copy link
Contributor

As with syntax highlight - it's part of theming editorBracketHighlight.foregroundN #129231 (comment)
Please do not hijack other's issues - there are umbrella issues that track this feature e.g. #128465

@Raydir
Copy link
Author

Raydir commented Aug 23, 2021

@IllusionMH
ahm.. why should one want vscode to override the definied Colors within an extension by default?
should the option "editor.bracketPairColorization.enabled" not be passiv by default?

@hediet
Copy link
Member

hediet commented Aug 23, 2021

should the option "editor.bracketPairColorization.enabled" not be passiv by default?

We enabled it temporarily for Insiders to get early feedback before we turn the feature off by default and roll it out to stable.

@Raydir Raydir closed this as completed Aug 23, 2021
@Raydir
Copy link
Author

Raydir commented Aug 23, 2021

fine by me, thanx for the responses.

To be clear:
Me for myself I do like the feature... i just got several persons "behind" me, that are using my highlighting and those will be questioning me directly ;)

@hediet
Copy link
Member

hediet commented Aug 23, 2021

Btw. as a theme author, you can customize the colors used for colorizing bracket pairs!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants