Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore ways to make terminal rendering edge cases more reliable #131580

Closed
Tyriar opened this issue Aug 24, 2021 · 5 comments
Closed

Explore ways to make terminal rendering edge cases more reliable #131580

Tyriar opened this issue Aug 24, 2021 · 5 comments
Assignees
Labels
polish Cleanup and polish issue terminal Integrated terminal issues terminal-rendering
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Aug 24, 2021

Sometimes issues like these are reported where something goes horribly wrong with the gpu support:

image

I believe that this is likely due to either browser bugs or hardware issues as I've never been able to reproduce them. We should devote some time to try reproduce some of these problems and see if we can detect and fallback to the DOM renderer for these cases. For example one idea that may or may not work is if we created the texture for and made sure that all of its sides are within the glyph?

@Tyriar Tyriar added polish Cleanup and polish issue terminal Integrated terminal issues terminal-rendering labels Aug 24, 2021
@Tyriar Tyriar added this to the September 2021 milestone Aug 24, 2021
@Tyriar
Copy link
Member Author

Tyriar commented Sep 2, 2021

Related: xtermjs/xterm.js#3449

@Tyriar
Copy link
Member Author

Tyriar commented Sep 9, 2021

From @SHoogland in #131389

image
On a Dell U2412M display with a resolution of 1920x1200 this weird visual issue occurs in the terminal

@SHoogland
Copy link

#131389 (comment)
To answer this question, and add some more info: disabling integrated gpu acceleration does fix the issue!

@Tyriar
Copy link
Member Author

Tyriar commented Sep 13, 2021

@SHoogland yep thanks, that will fix pretty much all the rendering issues but rendering in the terminal will be significantly slower

@Tyriar
Copy link
Member Author

Tyriar commented Dec 8, 2022

Closing as things are better now and this was more of a plan item

@Tyriar Tyriar closed this as completed Dec 8, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jan 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
polish Cleanup and polish issue terminal Integrated terminal issues terminal-rendering
Projects
None yet
Development

No branches or pull requests

3 participants