Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed test message does not get shown in the UI when no location is attached #131898

Closed
mxschmitt opened this issue Aug 30, 2021 · 2 comments
Closed
Assignees
Labels
author-verification-requested Issues potentially verifiable by issue author bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders testing Built-in testing support verified Verification succeeded

Comments

@mxschmitt
Copy link
Member

Issue Type: Bug

Currently when a test gets marked as failing with the new Testing API, I found no way to see the attached error messages:

options.failed(item, new vscode.TestMessage('Timeout!'));

I can workaround it by adding manual file/line/column locations.

Feel free to close it if its intended.

VS Code version: Code - Insiders 1.60.0-insider (Universal) (b71e20c, 2021-08-26T05:13:21.489Z)
OS version: Darwin x64 20.6.0
Restricted Mode: No

System Info
Item Value
CPUs Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz (12 x 2600)
GPU Status 2d_canvas: enabled
gpu_compositing: enabled
metal: disabled_off
multiple_raster_threads: enabled_on
oop_rasterization: enabled
opengl: enabled_on
rasterization: enabled
skia_renderer: disabled_off_ok
video_decode: enabled
webgl: enabled
webgl2: enabled
Load (avg) 3, 5, 6
Memory (System) 16.00GB (0.02GB free)
Process Argv --crash-reporter-id 53a4f2a9-696b-4193-ae04-5dfa7b9e90d3
Screen Reader no
VM 0%
Extensions (33)
Extension Author (truncated) Version
quitcontrol-vscode art 4.0.0
code-gnu-global aus 0.2.2
vscode-tailwindcss bra 0.6.14
vscode-markdownlint Dav 0.43.2
vscode-eslint dba 2.1.23
githistory don 0.6.18
xml Dot 2.5.1
gitlens eam 11.6.0
github-actions for 0.0.1
codespaces Git 1.0.3
copilot Git 1.4.2535
go gol 0.27.1
vscode-peacock joh 3.9.1
vscode-clangd llv 0.1.13
dotenv mik 1.0.1
language-gettext mro 0.2.0
vscode-docker ms- 1.16.0
playwright ms- 0.0.4
python ms- 2021.8.1159798656
vscode-pylance ms- 2021.8.3
jupyter ms- 2021.8.2031173646
jupyter-keymap ms- 1.0.0
remote-ssh ms- 0.65.7
remote-ssh-edit ms- 0.65.7
vsliveshare ms- 1.0.4761
idl myt 0.3.1
java red 0.81.0
vscode-commons red 0.0.6
vscode-yaml red 0.22.0
mdx sil 0.1.0
pdf tom 1.1.0
vscode-java-debug vsc 0.35.0
vscode-java-test vsc 0.31.3
A/B Experiments
vsliv695:30137379
vsins829:30139715
vsliv368cf:30146710
vsreu685:30147344
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
pythonvspyt639:30291487
pythontb:30258533
vshan820:30294714
pythonvsuse255:30319630
3f5j7703:30294757
vscod805cf:30301675
vsccppwtct:30312693
bridge0708:30335490
pygetstartedt2:30353727
dockerwalkthru:30348713
bridge0723:30353136
javagetstartedt:30350119
pydsgst2:30356659

@connor4312
Copy link
Member

I think in this case we should just show it on the first line of the test / treat the "range" as if it's the entire test.

@connor4312 connor4312 added bug Issue identified by VS Code Team member as probable bug testing Built-in testing support labels Aug 30, 2021
@connor4312 connor4312 added this to the September 2021 milestone Aug 30, 2021
@TylerLeonhardt TylerLeonhardt added author-verification-requested Issues potentially verifiable by issue author and removed author-verification-requested Issues potentially verifiable by issue author labels Sep 29, 2021
@roblourens roblourens added the verified Verification succeeded label Oct 1, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Oct 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
author-verification-requested Issues potentially verifiable by issue author bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders testing Built-in testing support verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

5 participants
@roblourens @connor4312 @TylerLeonhardt @mxschmitt and others