Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminal now supports linking local file paths containing '$' #132027

Merged
merged 3 commits into from Oct 22, 2021
Merged

Terminal now supports linking local file paths containing '$' #132027

merged 3 commits into from Oct 22, 2021

Conversation

brajkowski
Copy link
Contributor

Fixes #129911

@meganrogge meganrogge added this to the October 2021 milestone Oct 1, 2021
@ghost
Copy link

ghost commented Oct 22, 2021

CLA assistant check
All CLA requirements met.

Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great thanks, I added tests for it too

@Tyriar Tyriar merged commit b6aa001 into microsoft:main Oct 22, 2021
@Tyriar
Copy link
Member

Tyriar commented Oct 22, 2021

Opps I see you didn't sign the CLA, this should be fine as the PR is super trivial (reverting the change and redoing the 2 $ removals would be silly). For any future PRs you will want to sign the CLA.

@brajkowski
Copy link
Contributor Author

Thanks @Tyriar! I just signed the CLA too -- sorry about that!

@brajkowski brajkowski deleted the issue-129911 branch October 25, 2021 01:44
@Tyriar
Copy link
Member

Tyriar commented Oct 25, 2021

Cheers 🙂

@github-actions github-actions bot locked and limited conversation to collaborators Dec 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clicking on terminal in a pathname that contains a $ doesn't open the file
3 participants