Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git warnings show an error popup with cancel button #132208

Open
DetachHead opened this issue Sep 3, 2021 · 3 comments
Open

git warnings show an error popup with cancel button #132208

DetachHead opened this issue Sep 3, 2021 · 3 comments
Assignees
Labels
feature-request Request for new features or functionality git GIT issues
Milestone

Comments

@DetachHead
Copy link

DetachHead commented Sep 3, 2021

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version: 1.59.1
  • OS Version: windows 10

Steps to Reproduce:

  1. trigger a warning (ie. try to add a file with CRLF)

image

the icon should be more like
image

and the "Cancel" button should say "OK". arguably, they shouldn't even be modal popups and instead they should just appear as a notification on the bottom right

@eamodio eamodio added git GIT issues feature-request Request for new features or functionality labels Sep 15, 2021
@eamodio eamodio added this to the Backlog milestone Sep 15, 2021
@eamodio
Copy link
Contributor

eamodio commented Sep 15, 2021

This is a tricky one, since for some messages I agree, and other warrant a modal. Right now we don't distinguish between many types of possible errors

@DetachHead
Copy link
Author

another example:
image

this one is pretty bad because it's nonsensical for multiple reasons:

  • clicking "cancel" stages the change anyway
  • it says "the following paths" but doesn't actually include that part of the error

@DetachHead
Copy link
Author

image

@lszomoru lszomoru assigned lszomoru and unassigned eamodio Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality git GIT issues
Projects
None yet
Development

No branches or pull requests

3 participants