Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SettingsEditor2: Cannot read property 'getElementsByName' exception #132865

Closed
Tyriar opened this issue Sep 10, 2021 · 0 comments
Closed

SettingsEditor2: Cannot read property 'getElementsByName' exception #132865

Tyriar opened this issue Sep 10, 2021 · 0 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders settings-editor VS Code settings editor issues verified Verification succeeded

Comments

@Tyriar
Copy link
Member

Tyriar commented Sep 10, 2021

Repro was open OSS when settings editor and others are getting restored and close them during init. Looks like a listener is sticking around reacting to the terminal's refresh available profiles call which re-registered some config keys.

image

@roblourens roblourens added bug Issue identified by VS Code Team member as probable bug settings-editor VS Code settings editor issues labels Sep 13, 2021
@roblourens roblourens added this to the September 2021 milestone Sep 13, 2021
@mjbvz mjbvz added the verified Verification succeeded label Sep 29, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Oct 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders settings-editor VS Code settings editor issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants
@roblourens @Tyriar @mjbvz and others