Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spawn the extension host process from the shared process #133445

Merged
merged 1 commit into from Sep 20, 2021
Merged

Spawn the extension host process from the shared process #133445

merged 1 commit into from Sep 20, 2021

Conversation

alexdima
Copy link
Member

@alexdima alexdima commented Sep 20, 2021 •
edited

No description provided.

@alexdima alexdima self-assigned this Sep 20, 2021
@alexdima alexdima added this to the September 2021 milestone Sep 20, 2021
@alexdima
Copy link
Member Author

Merging to get it into tomorrow's build

@alexdima alexdima merged commit 18cde69 into main Sep 20, 2021
@alexdima alexdima deleted the alex/ext-host-shared-process branch September 20, 2021 16:30
@bpasero
Copy link
Member

bpasero commented Sep 21, 2021 •
edited

The changes LGTM. Maybe propertyIsDynamicEvent could be renamed to propertyIsScopedEvent, but not a big deal. I find both "dynamic" and "scoped" not the best word to describe what it is because the fact that the event is "scoped" is rather implemented by the implementation of the service and not enforced by the IPC library. But I also do not really have a better suggestion. I think it is best described as: a concept in our IPC library that allows a method to return an event (as opposed to a property returning an event). In that regard, dynamic might be better ;)

alexdima added a commit that referenced this pull request Sep 24, 2021
@alexdima
Use onDynamic* instead of onScoped* for events that are returned …
be33a77 
…from method calls (#133445)
@alexdima
Copy link
Member Author

👍 Renamed them back -- be33a77

@github-actions github-actions bot locked and limited conversation to collaborators Nov 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bpasero bpasero Awaiting requested review from bpasero

Assignees

@alexdima alexdima

Labels
None yet
Projects
None yet
Milestone
September 2021
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alexdima @bpasero