Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show path label on diff editors when other file with same name but different path is open #133616

Closed
goldst opened this issue Sep 22, 2021 · 1 comment
Labels
feature-request Request for new features or functionality *out-of-scope Posted issue is not in scope of VS Code workbench-editors Managing of editor widgets in workbench window
Milestone

Comments

@goldst
Copy link
Contributor

goldst commented Sep 22, 2021

@bpasero implemented a path label for diff editors as discussed in #110694:

image

I found the following edge case in which the label doesn't work as expected and was asked to treat this as a separate issue:

grafik

Here, there are two different workbenchTestServices.ts files opened, one in .../common and one in .../browser, but only one of them is in a diff. I think both tabs should have a label here, because they would if both of them were a normal tab.

With other words: when two files with the same name but different paths are opened, I would expect both tabs to have a label with their respective path, even when one of the files is opened in diff.

@bpasero bpasero added diff-editor Diff editor mode issues feature-request Request for new features or functionality labels Sep 22, 2021
@bpasero bpasero added this to the Backlog milestone Sep 22, 2021
@bpasero bpasero added the workbench-editors Managing of editor widgets in workbench window label Sep 30, 2021
@alexdima alexdima removed the diff-editor Diff editor mode issues label Oct 18, 2021
@bpasero bpasero added the *out-of-scope Posted issue is not in scope of VS Code label Dec 6, 2022
@VSCodeTriageBot
Copy link
Collaborator

We closed this issue because we don't plan to address it in the foreseeable future. If you disagree and feel that this issue is crucial: we are happy to listen and to reconsider.

If you wonder what we are up to, please see our roadmap and issue reporting guidelines.

Thanks for your understanding, and happy coding!

@VSCodeTriageBot VSCodeTriageBot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality *out-of-scope Posted issue is not in scope of VS Code workbench-editors Managing of editor widgets in workbench window
Projects
None yet
Development

No branches or pull requests

4 participants