Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

debug: toolbar does not update if focused thread no longer exists #133623

Closed
suzmue opened this issue Sep 22, 2021 · 2 comments · Fixed by #133637
Closed

debug: toolbar does not update if focused thread no longer exists #133623

suzmue opened this issue Sep 22, 2021 · 2 comments · Fixed by #133637
Assignees
@roblourens
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone
November 2021

Comments

@suzmue
Copy link
Contributor

suzmue commented Sep 22, 2021

  • VS Code Version: 1.60.1
  • OS Version: darwin/amd64

Steps to Reproduce:
Reported in the vscode-go repo: golang/vscode-go#1648

All threads are stopped expected toolbar to be:

Screen Shot 2021-09-22 at 12 39 23 PM

Instead got:
Screen Shot 2021-09-22 at 12 39 09 PM

This occurs when a stopped event is returned with no threadId AND the previously focused thread no longer exists, then the toolbar is left in the running state with the pause button enabled.

All of the active threads are paused:
Screen Shot 2021-09-22 at 12 25 40 PM

But the focused thread is still running, but actually does not exist anymore:
Screen Shot 2021-09-22 at 12 25 52 PM

The focused thread should be cleared if the thread no longer exists.
@hyangah hyangah mentioned this issue Sep 22, 2021
Closed
@suzmue suzmue mentioned this issue Sep 22, 2021
Merged
@roblourens roblourens added bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues labels Oct 13, 2021
@roblourens roblourens added this to the October 2021 milestone Oct 13, 2021
@rchiodo rchiodo added the verified Verification succeeded label Dec 2, 2021
@roblourens roblourens added the author-verification-requested Issues potentially verifiable by issue author label Dec 2, 2021
@roblourens
Copy link
Member

@suzmue I assume you tested the PR that you sent, but would appreciate you double-checking that it is fixed in our build since I'm not sure how to trigger the issue, thanks!

@rchiodo
Copy link
Contributor

rchiodo commented Dec 2, 2021

/verified

At least I think so.

I ran the steps here:
golang/vscode-go#1648 (comment)

And they work now.

@github-actions github-actions bot locked and limited conversation to collaborators Jan 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Milestone
November 2021
Development

Successfully merging a pull request may close this issue.

clear focused thread if it does not exist suzmue/vscode
4 participants
@roblourens @suzmue @rchiodo and others