debug: read/write memory support #133643
Merged
debug: read/write memory support #133643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connor4312
added
the
debug
|
Moving to November since this wasn't merged in October. |
This implements the core memory "model" for debugging that reflects DAP, in `debugModel.ts`. It also implements a filesystem provider based on that in `debugMemory.ts`, for tentative application in the hex editor. Finally it adds context menu items for these. This works with changes in mock debug, but for some reason reopening the ".bin" file in the hex editor results in a blank editor. Still need to look at that. Ultimately though, as indicated in #126268, we'll probably want custom commands for the hex editor to call as low level read/write is not supported in the stable API. Also, the file API doesn't represent the "unreadable" ranges which DAP supports.
connor4312
force-pushed
the
connor4312/debug-read-memory
branch
from
fe52357
to
29bde31
Compare
connor4312
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the core memory "model" for debugging that reflects
DAP, in
debugModel.ts. It also implements a filesystem provider basedon that in
debugMemory.ts, for application in the hex editor.Finally it adds context menu items for these. This works with changes in
mock debug and microsoft/vscode-hexeditor#309