Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add automatic opening behaviour to side panel #134017

Closed
lszomoru opened this issue Sep 28, 2021 · 3 comments
Closed

Add automatic opening behaviour to side panel #134017

lszomoru opened this issue Sep 28, 2021 · 3 comments
Assignees
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders layout General VS Code workbench layout issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@lszomoru
Copy link
Member

Testing #133919

Some notes as I have played around with the second panel:

  • It took me quite some time to figure out that first I need to toggle the side panel before I can drop things. It would be great if we would detect that something is being dragged to the opposite side of the primary panel and we would open the panel and provide the visual cue to drop the view container/view.
  • I could not figure out why some view containers/views cannot be placed in the secondary panel. Ideally all of them should support to be in the secondary panel. If for some reason that is not the case, we need to have a clear visual indicator of the view containers/views that cannot be placed in the secondary panel.
  • I think we should have a setting the controls whether the panel is automatically hidden when the last view container/view is being dragged out. As I was playing around with things, I always had to toggle the secondary view before I could drop something.
  • The pin icon in the secondary panel does not seem to be centered (this might be a timeline view issue)
    image
@sbatten sbatten added feature-request Request for new features or functionality layout General VS Code workbench layout issues labels Oct 4, 2021
@sbatten sbatten added this to the On Deck milestone Oct 4, 2021
@sbatten sbatten changed the title Second Panel - exploratory feedback Add automatic opening behaviour to side panel Oct 4, 2021
@sbatten sbatten modified the milestones: On Deck, October 2021 Oct 19, 2021
@sbatten
Copy link
Member

sbatten commented Oct 26, 2021

To Verify:

  1. Enable side panel with workbench.experimental.sidePanel.enabled
  2. Reload window for good measure
  3. With the side panel NOT visible, drag a view/container from the activity bar/side bar/panel to the side of the editor where the side panel should be

Verify it pops out allowing you to drop the view (this should function just like the panel)

@sbatten sbatten added the verification-needed Verification of issue is requested label Oct 26, 2021
@joyceerhl joyceerhl added the verified Verification succeeded label Oct 26, 2021
@joyceerhl
Copy link
Contributor

Perhaps the placeholder text could do with some padding (though I don't know how I managed to get the side panel to show up without dragging and dropping...)
image

@sbatten
Copy link
Member

sbatten commented Oct 27, 2021

thanks @joyceerhl created and fixed with #135970

@github-actions github-actions bot locked and limited conversation to collaborators Dec 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders layout General VS Code workbench layout issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants
@lszomoru @sbatten @joyceerhl and others