Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emmet needs command-based activation events #134149

Closed
Isabelacosta12 opened this issue Sep 29, 2021 · 8 comments
Closed

Emmet needs command-based activation events #134149

Isabelacosta12 opened this issue Sep 29, 2021 · 8 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug emmet Emmet related issues insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue verified Verification succeeded
Milestone

Comments

@Isabelacosta12
Copy link

Isabelacosta12 commented Sep 29, 2021

the emmet function doesn't work

@IllusionMH
Copy link
Contributor

/needsMoreInfo

@yvvt0379
Copy link

the emmet function doesn't work

How doesn't it work?

@rbuckton
Copy link
Member

rbuckton commented Oct 18, 2021

This happens for most of the emmet commands I've tried:

image
image

Version: 1.62.0-insider (user setup)
Commit: 34eeebd
Date: 2021-10-15T05:16:57.817Z (2 days ago)
Electron: 13.5.1
Chrome: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Windows_NT x64 10.0.22000

@rbuckton
Copy link
Member

I can verify that Emmet support is enabled as well:
image

@rzhao271
Copy link
Contributor

Thanks @rbuckton. Emmet currently requires the user to open an HTML/CSS/JSX file to activate. Did you try running it in another file type, or in a freshly opened workspace?

@rzhao271 rzhao271 added the emmet Emmet related issues label Oct 18, 2021
@rbuckton
Copy link
Member

It started working on one machine, but not one of my others, and I had an HTML file open at the time.

Even if it is specific to the open editor, I would think the command would be disabled or would report a more user friendly message when it's not supported.

@rzhao271
Copy link
Contributor

I added a change that makes it so that

  1. The commands should not show up when one is not viewing a file, such as when they are in the Settings editor.
  2. Issuing a command activates the extension, which should reduce the occurrence of those "command not found" messages.

@rzhao271 rzhao271 added bug Issue identified by VS Code Team member as probable bug polish Cleanup and polish issue and removed info-needed Issue requires more information from poster labels Oct 19, 2021
@rzhao271 rzhao271 added this to the October 2021 milestone Oct 19, 2021
@rzhao271 rzhao271 changed the title Emmet Emmet needs command-based activation events Oct 25, 2021
@mjbvz mjbvz added the verified Verification succeeded label Oct 27, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Dec 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug emmet Emmet related issues insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

7 participants
@IllusionMH @rbuckton @rzhao271 @mjbvz @yvvt0379 @Isabelacosta12 and others