Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Don't ignore the indent settings in advanced wrapping mode #134171

Merged
merged 3 commits into from Oct 27, 2021

Conversation

byteit101
Copy link
Contributor

This PR fixes #132220
and
This PR fixes #120844

This still works in one pass by using negative text-indent with matching
padding to generate a CSS-based hanging indent that we can measure.
This could be upgraded to the hanging modifier in the far future. (No browsers support it at this time)

Fixes microsoft#132220
Fixes microsoft#120844

This still works in one pass by using negative text-indent with matching
padding to generate a CSS-based hanging indent that we can measure.
This could be upgraded to the `hanging` modifier in the far future.
@ghost
Copy link

ghost commented Sep 29, 2021

CLA assistant check
All CLA requirements met.

@byteit101
Copy link
Contributor Author

byteit101 commented Sep 29, 2021

Text I used to verify this fix (I didn't see any advanced wrapping test file):

W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W

i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i

											This is a normal long line that has normal words on it. No abnormal words here, though maybe that last one could count as one.

		Very wide glyphs:
		𒅃 𒈓 𒍼 𒅃 𒌧 𒅃 𒈓 𒍼 𒅃 𒌧 𒅃 𒈓 𒍼 𒅃 𒌧 𒅃 𒈓 𒍼 𒅃 𒌧 𒅃 𒈓 𒍼 𒅃 𒌧 𒈓 𒍼 𒅃 𒌧 𒈓 𒍼

		𒐫 𒐫 𒐫 𒐫 𒐫 𒐫 𒐫 𒐫 𒐫 𒐫 𒐫 𒐫 𒐫 𒐫 𒐫 𒐫 𒐫 𒐫 𒐫 𒐫 𒐫 𒐫

		﷽ ﷽ ﷽ ﷽ ﷽ ﷽ ﷽ ﷽ ﷽ ﷽ ﷽ ﷽ ﷽ ﷽ ﷽ ﷽ ﷽ ﷽ ﷽ ﷽ ﷽ ﷽ ﷽ ﷽ ﷽ ﷽ ﷽ ﷽ ﷽ ﷽ ﷽ ﷽ ﷽

		Above is U+12143, U+12213, U+1237C, U+12327 (Cuneiform block characters), then U+1242B (CUNEIFORM NUMERIC SIGN NINE SHAR2), then finally U+FDFD (ARABIC LIGATURE BISMILLAH AR-RAHMAN AR-RAHEEM)

Screenshots of correctly wrapping & indenting with this change:

Monospace font (wide non-Latin characters fixed):
mono-advanced

Proportional font (all characters fixed):
sans-advanced

@alexdima alexdima added this to the October 2021 milestone Sep 30, 2021
@alexdima alexdima added the editor-wrapping Editor line wrapping issues label Oct 27, 2021
@alexdima
Copy link
Member

Thank you!

@alexdima alexdima merged commit d578207 into microsoft:main Oct 27, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Dec 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
editor-wrapping Editor line wrapping issues
Projects
None yet
2 participants