Minimap slider does not full width every time

[ansidev]

Does this issue occur when all extensions are disabled?: Yes/No

• Version: 1.60.2
• Commit: 7f6ab54
• Date: 2021-09-22T11:59:27.195Z (1 wk ago)
• Electron: 13.1.8
• Chrome: 91.0.4472.164
• Node.js: 14.16.0
• V8: 9.1.269.39-electron.0
• OS: Darwin x64 20.6.0

Steps to Reproduce:

1. Open a large file with a long line to be scrollable over the file (x and y axis).
2. Scroll right.
3. Hover on minimap.

Actual: The minimap slider does not have full width.
Expected: The minimap slider is always full width.

[alexdima]

@ansidev Could you please also add a screenshot, I am not sure what you are referring to.

[ansidev]

@alexdima Please check.

VSCode_minimap_bug.mov

[AiverReaver]

@alexdima can I work on this issue. if yes code pointers to investigate.

[alexdima]

PR welcome. code pointer

[AiverReaver]

thanks

[AiverReaver]

@alexdima what would be the expected behaviour of the minimap for a horizontal scroll?

[alexdima]

@AiverReaver I think we could just remove that the slider moves horizontally and let it stay put.

[ansidev]

this._sliderHorizontal.setLeft(horizontalSliderLeft); // set offset left for minimap slider
this._sliderHorizontal.setWidth(this._model.options.minimapWidth - horizontalSliderLeft); // update minimap slider width

I think it should be:

this._sliderHorizontal.setLeft(0);
this._sliderHorizontal.setWidth(this._model.options.minimapWidth);

[ansidev]

this._sliderHorizontal.setLeft(horizontalSliderLeft); // set offset left for minimap slider
this._sliderHorizontal.setWidth(this._model.options.minimapWidth - horizontalSliderLeft); // update minimap slider width

These lines of code should work if you support scrolling horizontally for the minimap slider. At this time, we can only scroll the minimap slider vertically.

[AiverReaver]

@AiverReaver I think we could just remove that the slider moves horizontally and let it stay put.

Okay, I can do that but I think it would be much better if we allow horizontal scroll in minimap. what do you think about that?