Allows settings to override language contributed bracket pair configurations.

[hediet]

This PR fixes #131412

TODOs:

• The new settings must be added to the JSON Schema

[alexdima]

@hediet Could you please fix the tests.

[alexdima]

I've left notes, we can also discuss.

[alexdima]

I suggest to move the validation of brackets (i.e. that empty brackets are not allowed to ResolvedLanguageConfiguration). Otherwise, we would need to check for empty strings in all consumers of ResolvedLanguageConfiguration.

[alexdima]

You can define them together with the other non-editor options yet still editor.* settings at

vscode/src/vs/editor/common/config/commonEditorConfig.ts

Line 471 in df994ef

const editorConfiguration: IConfigurationNode = {

[alexdima]

if (!e.affectsConfiguration('editor')) {
  return;
}

[hediet]

I do it like this now:

const customizedLanguageConfigKeys = {
	brackets: 'editor.language.brackets',
	colorizedBracketPairs: 'editor.language.colorizedBracketPairs'
};

// ...

const languageConfigKeys = new Set(Object.values(customizedLanguageConfigKeys));

const globalConfigChanged = e.change.keys.some((k) =>
				languageConfigKeys.has(k)
			);
const localConfigChanged = e.change.overrides
    .filter(([overrideLangName, keys]) =>
        keys.some((k) => languageConfigKeys.has(k))
    )
    .map(([overrideLangName]) => this.modeService.getLanguageIdentifier(overrideLangName));

if (globalConfigChanged) {
    this.configurations.clear();
    this.onDidChangeEmitter.fire(new LanguageConfigurationServiceChangeEvent(undefined));
} else {
    for (const languageIdentifier of localConfigChanged) {
        if (languageIdentifier) {
            this.configurations.delete(languageIdentifier.id);
            this.onDidChangeEmitter.fire(new LanguageConfigurationServiceChangeEvent(languageIdentifier));
        }
    }
}

[alexdima]

Looks very good! Just one last problem I just noticed.

[alexdima]

This is not a test, we should not use the TestLanguageConfigurationService here

[hediet]

Fixed.